adb: fix mkdirs / adb pull with relative paths, fix win32 issues
Relative paths were being prefixed with OS_PATH_SEPARATOR on unix and
win32 causing adb to incorrectly try to make directories at the root.
Plus, absolute paths didn't work on win32 (C: got prefixed into \C:).
This fix is to use dirname (available on win32 via mingw's crt) to do
the messy parsing.
I added a test for the relative path case.
Change-Id: Ibb0a4a8ec7756351d252a4d267122ab18e182858
Signed-off-by: Spencer Low <CompareAndSwap@gmail.com>
diff --git a/adb_utils.h b/adb_utils.h
index 8c5208c..739efcc 100644
--- a/adb_utils.h
+++ b/adb_utils.h
@@ -21,7 +21,11 @@
bool getcwd(std::string* cwd);
bool directory_exists(const std::string& path);
+
+// Like the regular basename and dirname, but thread-safe on all
+// platforms and capable of correctly handling exotic Windows paths.
std::string adb_basename(const std::string& path);
+std::string adb_dirname(const std::string& path);
bool mkdirs(const std::string& path);