Explain adb client/server version mismatch better.
"Out of date" is only probably true. You might equally well have an older
client talking to a newer server. So tell the truth and include the actual
version numbers.
Change-Id: I821de88f5baf65bf2623363129c60c496b407bff
diff --git a/adb_client.cpp b/adb_client.cpp
index 63cb3c3..984910d 100644
--- a/adb_client.cpp
+++ b/adb_client.cpp
@@ -195,14 +195,15 @@
adb_sleep_ms(3000);
// fall through to _adb_connect
} else {
- // if server was running, check its version to make sure it is not out of date
+ // If a server is already running, check its version matches.
int version = ADB_SERVER_VERSION - 1;
- // if we have a file descriptor, then parse version result
+ // If we have a file descriptor, then parse version result.
if (fd >= 0) {
std::string version_string;
if (!ReadProtocolString(fd, &version_string, error)) {
- goto error;
+ adb_close(fd);
+ return -1;
}
adb_close(fd);
@@ -214,8 +215,8 @@
return -1;
}
} else {
- // if fd is -1, then check for "unknown host service",
- // which would indicate a version of adb that does not support the
+ // If fd is -1 check for "unknown host service" which would
+ // indicate a version of adb that does not support the
// version command, in which case we should fall-through to kill it.
if (*error != "unknown host service") {
return fd;
@@ -223,7 +224,8 @@
}
if (version != ADB_SERVER_VERSION) {
- printf("adb server is out of date. killing...\n");
+ printf("adb server version (%d) doesn't match this client (%d); killing...\n",
+ version, ADB_SERVER_VERSION);
fd = _adb_connect("host:kill", error);
if (fd >= 0) {
adb_close(fd);
@@ -253,9 +255,6 @@
D("adb_connect: return fd %d", fd);
return fd;
-error:
- adb_close(fd);
- return -1;
}