Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / a4f9c17d4f2d03ab0e9936f0be878602513a86ea
commita4f9c17d4f2d03ab0e9936f0be878602513a86ea[log] [tgz]
authorJosh Gao <jmgao@google.com>Thu Jul 28 18:09:48 2016 -0700
committerJosh Gao <jmgao@google.com>Mon Aug 01 12:36:04 2016 -0700
tree4b2b4c82fcb54bad2182a81bfe6124ea5f2bdcb6
parentcde85bfe4478b2dcacae0775e236a31ca76275fb [diff]
adb: fix stat on Windows.

stat on Windows fails with ENOENT when passed a path with a trailing
slash or backslash, regardless of whether the target is actually a
directory. Emulate the correct POSIX behavior by stripping trailing
path separators and then checking if the target is a directory if
successful.

Bug: http://b/30481559
Bug: https://code.google.com/p/android/issues/detail?id=214633
Change-Id: I1d398d19a9bce1ecb3fdc4aabc31aa98c82c3f93
Test: Relevant adb_tests pass on Linux and Windows 10.
7 files changed
tree: 4b2b4c82fcb54bad2182a81bfe6124ea5f2bdcb6
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_listeners_test.cpp
  19. adb_trace.cpp
  20. adb_trace.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. Android.mk
  25. commandline.cpp
  26. console.cpp
  27. CPPLINT.cfg
  28. diagnose_usb.cpp
  29. diagnose_usb.h
  30. fdevent.cpp
  31. fdevent.h
  32. fdevent_test.cpp
  33. fdevent_test.h
  34. file_sync_client.cpp
  35. file_sync_service.cpp
  36. file_sync_service.h
  37. framebuffer_service.cpp
  38. get_my_path_darwin.cpp
  39. get_my_path_linux.cpp
  40. jdwp_service.cpp
  41. line_printer.cpp
  42. line_printer.h
  43. MODULE_LICENSE_APACHE2
  44. mutex_list.h
  45. NOTICE
  46. OVERVIEW.TXT
  47. protocol.txt
  48. remount_service.cpp
  49. remount_service.h
  50. security_log_tags.h
  51. services.cpp
  52. services.h
  53. SERVICES.TXT
  54. set_verity_enable_state_service.cpp
  55. shell_service.cpp
  56. shell_service.h
  57. shell_service_protocol.cpp
  58. shell_service_protocol_test.cpp
  59. shell_service_test.cpp
  60. socket.h
  61. socket_test.cpp
  62. sockets.cpp
  63. sockets.dia
  64. SYNC.TXT
  65. sysdeps.h
  66. sysdeps_test.cpp
  67. sysdeps_unix.cpp
  68. sysdeps_win32.cpp
  69. sysdeps_win32_test.cpp
  70. test_adb.py
  71. test_device.py
  72. transport.cpp
  73. transport.h
  74. transport_local.cpp
  75. transport_test.cpp
  76. transport_usb.cpp
  77. usb_linux.cpp
  78. usb_linux_client.cpp
  79. usb_osx.cpp
  80. usb_windows.cpp