Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / 3e9e74ef9fd714931820d31afacbd1573f440e98
commit3e9e74ef9fd714931820d31afacbd1573f440e98[log] [tgz]
authorElliott Hughes <enh@google.com>Wed May 03 17:25:34 2017 -0700
committerElliott Hughes <enh@google.com>Fri May 05 12:50:16 2017 -0700
treeee94bc0c6842fbaa46450821a0cf18702260ab9d
parentd6606c1024587774f68bf16d1e5c4669af4ec73d [diff]
Improve udev failure diagnostics.

A couple of folks had trouble understanding the existing message.

Before:

  8XV7N15917000596	no permissions (udev requires plugdev group membership); see [http://developer.android.com/tools/device.html]

After:

  8XV7N15917000596	no permissions (user buttmunch is not in the plugdev group); see [http://developer.android.com/tools/device.html]

This also fixes a libusb regression where we wouldn't show anything for
devices where we don't have permissions.

Bug: http://b/37707122
Test: ran "adb devices" as user buttmunch
Change-Id: I2fcd735ff4178145432b532a6e4dc8c93b2743fd
2 files changed
tree: ee94bc0c6842fbaa46450821a0cf18702260ab9d
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. adbd_auth.cpp
  25. Android.mk
  26. bugreport.cpp
  27. bugreport.h
  28. bugreport_test.cpp
  29. commandline.cpp
  30. commandline.h
  31. console.cpp
  32. CPPLINT.cfg
  33. diagnose_usb.cpp
  34. diagnose_usb.h
  35. fdevent.cpp
  36. fdevent.h
  37. fdevent_test.cpp
  38. fdevent_test.h
  39. file_sync_client.cpp
  40. file_sync_service.cpp
  41. file_sync_service.h
  42. framebuffer_service.cpp
  43. jdwp_service.cpp
  44. line_printer.cpp
  45. line_printer.h
  46. MODULE_LICENSE_APACHE2
  47. NOTICE
  48. OVERVIEW.TXT
  49. protocol.txt
  50. remount_service.cpp
  51. remount_service.h
  52. security_log_tags.h
  53. services.cpp
  54. services.h
  55. SERVICES.TXT
  56. set_verity_enable_state_service.cpp
  57. shell_service.cpp
  58. shell_service.h
  59. shell_service_protocol.cpp
  60. shell_service_protocol_test.cpp
  61. shell_service_test.cpp
  62. socket.h
  63. socket_spec.cpp
  64. socket_spec.h
  65. socket_spec_test.cpp
  66. socket_test.cpp
  67. sockets.cpp
  68. sockets.dia
  69. SYNC.TXT
  70. sysdeps.h
  71. sysdeps_test.cpp
  72. sysdeps_unix.cpp
  73. sysdeps_win32.cpp
  74. sysdeps_win32_test.cpp
  75. test_adb.py
  76. test_device.py
  77. trace.sh
  78. transport.cpp
  79. transport.h
  80. transport_local.cpp
  81. transport_mdns.cpp
  82. transport_mdns_unsupported.cpp
  83. transport_test.cpp
  84. transport_usb.cpp
  85. usb.h