Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / b14756a7754dbb46d6f7d0a7814b0bcc61741e67
commitb14756a7754dbb46d6f7d0a7814b0bcc61741e67[log] [tgz]
authorJosh Gao <jmgao@google.com>Fri Feb 02 14:38:04 2018 -0800
committerJosh Gao <jmgao@google.com>Tue Feb 06 12:59:06 2018 -0800
tree3a7e3f47f8b6de9e9f37f2286aac2eaf48b0e1f6
parent2b3db9e35c05c2653bb92c277ebe42f6fb322803 [diff]
adb: restore packet data length checks.

These checks were moved to after the read of the payload, which is too
late. Add a check before each read to avoid a heap buffer overflow.

Test: python test_device.py with x86_64 emulator, walleye
Change-Id: I86bcfaaa9004951cc52ad89af74680cf748e717d
2 files changed
tree: 3a7e3f47f8b6de9e9f37f2286aac2eaf48b0e1f6
  1. client/
  2. daemon/
  3. sysdeps/
  4. .clang-format ⇨ ../.clang-format-4
  5. adb.cpp
  6. adb.h
  7. adb_auth.h
  8. adb_auth_host.cpp
  9. adb_client.cpp
  10. adb_client.h
  11. adb_io.cpp
  12. adb_io.h
  13. adb_io_test.cpp
  14. adb_listeners.cpp
  15. adb_listeners.h
  16. adb_listeners_test.cpp
  17. adb_mdns.h
  18. adb_trace.cpp
  19. adb_trace.h
  20. adb_unique_fd.h
  21. adb_utils.cpp
  22. adb_utils.h
  23. adb_utils_test.cpp
  24. adbd_auth.cpp
  25. Android.bp
  26. Android.mk
  27. bugreport.cpp
  28. bugreport.h
  29. bugreport_test.cpp
  30. commandline.cpp
  31. commandline.h
  32. console.cpp
  33. CPPLINT.cfg
  34. diagnose_usb.cpp
  35. diagnose_usb.h
  36. fdevent.cpp
  37. fdevent.h
  38. fdevent_test.cpp
  39. fdevent_test.h
  40. file_sync_client.cpp
  41. file_sync_service.cpp
  42. file_sync_service.h
  43. framebuffer_service.cpp
  44. jdwp_service.cpp
  45. line_printer.cpp
  46. line_printer.h
  47. MODULE_LICENSE_APACHE2
  48. NOTICE
  49. OVERVIEW.TXT
  50. OWNERS
  51. protocol.txt
  52. remount_service.cpp
  53. remount_service.h
  54. security_log_tags.h
  55. services.cpp
  56. services.h
  57. SERVICES.TXT
  58. set_verity_enable_state_service.cpp
  59. shell_service.cpp
  60. shell_service.h
  61. shell_service_protocol.cpp
  62. shell_service_protocol_test.cpp
  63. shell_service_test.cpp
  64. socket.h
  65. socket_spec.cpp
  66. socket_spec.h
  67. socket_spec_test.cpp
  68. socket_test.cpp
  69. sockets.cpp
  70. sockets.dia
  71. SYNC.TXT
  72. sysdeps.h
  73. sysdeps_test.cpp
  74. sysdeps_unix.cpp
  75. sysdeps_win32.cpp
  76. sysdeps_win32_test.cpp
  77. test_adb.py
  78. test_device.py
  79. trace.sh
  80. transport.cpp
  81. transport.h
  82. transport_local.cpp
  83. transport_mdns.cpp
  84. transport_mdns_unsupported.cpp
  85. transport_test.cpp
  86. transport_usb.cpp
  87. usb.h