Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / d6662ece0d2098d71d0ebe745d4019b248c906a1
commitd6662ece0d2098d71d0ebe745d4019b248c906a1[log] [tgz]
authorYabin Cui <yabinc@google.com>Wed Aug 26 11:44:16 2015 -0700
committerYabin Cui <yabinc@google.com>Wed Aug 26 15:22:56 2015 -0700
tree08369f1b48102247ab2c13c12a49c3f026238c22
parent9e0f034f7f8bf2a30288f93cd764b4a2d1bf004f [diff]
adb: fix a fake data race on transport:kick reported by tsan.

It is reported by tsan as a double checked locking. But I think
it is not a real data race. Because I think the old code is able
to make sure t->kick() is only called once, and the caller of
kick_transport is not relying on the side-effect of calling
t->kick().
But as it is not perf critical, I don't mind breaking the double
checked locking pattern.

Bug: 23385662
Change-Id: Ie3597dd56bb514117c3865d2afcfd7c115731a78
1 file changed
tree: 08369f1b48102247ab2c13c12a49c3f026238c22
  1. client/
  2. daemon/
  3. .clang-format
  4. __init__.py
  5. adb.cpp
  6. adb.h
  7. adb_auth.cpp
  8. adb_auth.h
  9. adb_auth_client.cpp
  10. adb_auth_host.cpp
  11. adb_client.cpp
  12. adb_client.h
  13. adb_io.cpp
  14. adb_io.h
  15. adb_io_test.cpp
  16. adb_listeners.cpp
  17. adb_listeners.h
  18. adb_trace.h
  19. adb_utils.cpp
  20. adb_utils.h
  21. adb_utils_test.cpp
  22. adbd.rc
  23. Android.mk
  24. commandline.cpp
  25. console.cpp
  26. CPPLINT.cfg
  27. device.py
  28. fdevent.cpp
  29. fdevent.h
  30. file_sync_client.cpp
  31. file_sync_service.cpp
  32. file_sync_service.h
  33. framebuffer_service.cpp
  34. get_my_path_darwin.cpp
  35. get_my_path_linux.cpp
  36. jdwp_service.cpp
  37. MODULE_LICENSE_APACHE2
  38. mutex_list.h
  39. NOTICE
  40. OVERVIEW.TXT
  41. protocol.txt
  42. qemu_tracing.cpp
  43. qemu_tracing.h
  44. remount_service.cpp
  45. remount_service.h
  46. services.cpp
  47. SERVICES.TXT
  48. set_verity_enable_state_service.cpp
  49. sockets.cpp
  50. sockets.dia
  51. SYNC.TXT
  52. sysdeps.h
  53. sysdeps_win32.cpp
  54. test_adb.py
  55. test_device.py
  56. test_track_devices.cpp
  57. transport.cpp
  58. transport.h
  59. transport_local.cpp
  60. transport_test.cpp
  61. transport_usb.cpp
  62. usb_linux.cpp
  63. usb_linux_client.cpp
  64. usb_osx.cpp
  65. usb_windows.cpp