Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / modules / adb / 6bc77009177ba2de4c25a2c8f17bee826c0540a3
commit6bc77009177ba2de4c25a2c8f17bee826c0540a3[log] [tgz]
authorJosh Gao <jmgao@google.com>Thu Apr 18 16:39:30 2019 -0700
committerJosh Gao <jmgao@google.com>Wed Apr 24 12:59:42 2019 -0700
tree97b63d6b7c86394ab0a1dc40eedca8f7ce305378
parent4c0c9c90e1ae4fb8ef7312833a825bc3c3bee62b [diff]
Add a way to turn off unique_fd's operator int.

unique_fd's implicit conversion to int has led to tons of problems (see
all of the overloads for close, fdopen, fdopendir, etc.). Add a switch
that can turn it off, and reduce the ridiculous amount of work to fix up
callers by introducing a borrowed_fd type that can be constructed from
either int or unique_fd.

Test: treehugger
Change-Id: If77cf5cbcaddacdaec5919a15b3520fb68f51a62
26 files changed
tree: 97b63d6b7c86394ab0a1dc40eedca8f7ce305378
  1. client/
  2. daemon/
  3. fastdeploy/
  4. sysdeps/
  5. .clang-format ⇨ ../.clang-format-4
  6. adb.bash
  7. adb.cpp
  8. adb.h
  9. adb_auth.h
  10. adb_integration_test_adb.xml
  11. adb_integration_test_device.xml
  12. adb_io.cpp
  13. adb_io.h
  14. adb_io_test.cpp
  15. adb_listeners.cpp
  16. adb_listeners.h
  17. adb_listeners_test.cpp
  18. adb_mdns.h
  19. adb_trace.cpp
  20. adb_trace.h
  21. adb_unique_fd.cpp
  22. adb_unique_fd.h
  23. adb_utils.cpp
  24. adb_utils.h
  25. adb_utils_test.cpp
  26. Android.bp
  27. benchmark_device.py
  28. bugreport_test.cpp
  29. fdevent.cpp
  30. fdevent.h
  31. fdevent_test.cpp
  32. fdevent_test.h
  33. file_sync_protocol.h
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. OVERVIEW.TXT
  37. OWNERS
  38. protocol.txt
  39. security_log_tags.h
  40. services.cpp
  41. services.h
  42. SERVICES.TXT
  43. shell_protocol.h
  44. shell_service_protocol.cpp
  45. shell_service_protocol_test.cpp
  46. socket.h
  47. socket_spec.cpp
  48. socket_spec.h
  49. socket_spec_test.cpp
  50. socket_test.cpp
  51. sockets.cpp
  52. sockets.dia
  53. SYNC.TXT
  54. sysdeps.h
  55. sysdeps_test.cpp
  56. sysdeps_unix.cpp
  57. sysdeps_win32.cpp
  58. sysdeps_win32_test.cpp
  59. test_adb.py
  60. test_device.py
  61. trace.sh
  62. transport.cpp
  63. transport.h
  64. transport_benchmark.cpp
  65. transport_fd.cpp
  66. transport_local.cpp
  67. transport_test.cpp
  68. transport_usb.cpp
  69. types.h
  70. types_test.cpp
  71. usb.h