| commit | 0a0a7847beb0f05fdbdcc2bd8cc3d478bd47e379 | [log] [tgz] |
|---|---|---|
| author | Ulya Trafimovich <skvadrik@google.com> | Wed Jan 29 12:16:16 2020 +0000 |
| committer | Ulya Trafimovich <skvadrik@google.com> | Wed Jan 29 12:48:40 2020 +0000 |
| tree | 74a49f3849d0d2421c9a9fcad26e550279930a99 | |
| parent | 639075e58c42755243f7f60ec217f04dea3cf835 [diff] |
Drop useless check for PRODUCT_BOOT_JARS redefinition. It is not clear why this check exists; it seems to be unneeded, and removing it does not break any tests. PRODUCT_BOOT_JARS is a product variable, and therefore handled in a special way (unlike ordinary Make variables). It is substituted with a macro that inherits makefile-specific instances of this variable and merges them into one. This can be seen by adding debug output to the device-specific makefile. For example, add the following to device/generic/car/aosp_car_arm.mk: $(warning $(PRODUCT_BOOT_JARS)) The build will generate a warning similar to this: device/generic/car/aosp_car_arm.mk:21: warning: @inherit:build/make/target/product/aosp_arm.mk @inherit:device/generic/car/emulator/aosp_car_emulator.mk Test: lunch aosp_car_arm && m Change-Id: Ib5e09c6624dbd4db29105c67543a53caa490b818 Merged-In: I061b70b751ca00efa8f215dba8419d2b9e920403
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.