commit | 0f39599b9ace17d6b2cbb60828f27bd76674009b | [log] [tgz] |
---|---|---|
author | Mark Tabry <mtab@google.com> | Wed Oct 30 16:33:30 2019 -0700 |
committer | Mark Tabry <mtab@google.com> | Tue Nov 12 15:49:40 2019 -0800 |
tree | a109addf263ab44471916aa1e349b65c80cba19e | |
parent | 4fca1cff83c4ec3b4dbbdd6731c51a136231a236 [diff] |
Catch and log RuntimeExceptions thrown by VehicleHal and optionally propagate. Changes: - PropertyTimeout/RuntimeException on get() operation (metrics collection) is caught and logged - PropertyTimeout/RuntimeException on set() operation (sending VMS messages) is caught, logged, and propagated on eng and userdebug builds as an IllegalStateException - SESSION_START handshakes are sent synchronously to HAL in response to client handshake - Updated VmsHalServiceTest to enable rethrow by default - Tests added to validate error suppression, but no tests added to validate rethrow as this would require major refactoring due to VHAL operations being processed on a separate thread. Bug: 142879041 Bug: 137878135 Test: atest AndroidCarApiTest CarServiceTest CarServiceUnitTest Test: Manual testing on Hawk of crash propagation w/ modified HAL Change-Id: I6d615fa2764712444a1127bd52f21d3fa95b56e8
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.