commit | 14000f4d7f6c58e784da1ebdf2e8aa0109cf5bca | [log] [tgz] |
---|---|---|
author | Ulya Trafimovich <skvadrik@google.com> | Mon Jan 20 13:51:26 2020 +0000 |
committer | Ulya Trafimovich <skvadrik@google.com> | Tue Jan 21 13:34:35 2020 +0000 |
tree | 7e7ae938bbb4c50583f8782f7537f8d8eda5a881 | |
parent | 2379ac0373f837cec0e114301df0dbe08b015cf6 [diff] |
Drop useless check for PRODUCT_BOOT_JARS redefinition. It is not clear why this check exists; it seems to be unneeded, and removing it does not break any tests. PRODUCT_BOOT_JARS is a product variable, and therefore handled in a special way (unlike ordinary Make variables). It is substituted with a macro that inherits makefile-specific instances of this variable and merges them into one. This can be seen by adding debug output to the device-specific makefile. For example, add the following to device/generic/car/aosp_car_arm.mk: $(warning $(PRODUCT_BOOT_JARS)) The build will generate a warning similar to this: device/generic/car/aosp_car_arm.mk:21: warning: @inherit:build/make/target/product/aosp_arm.mk @inherit:device/generic/car/emulator/aosp_car_emulator.mk Test: $(ANDROID_BUILD_TOP)/vendor/google/build/build_test.bash --dist --incremental --shard-count=3 --shard=2 Test: lunch aosp_car_arm && m Test: lunch aosp_car_arm64 && m Test: lunch aosp_car_x86 && m Test: lunch aosp_car_x86_64 && m Test: lunch car_x86_64 && m Change-Id: I061b70b751ca00efa8f215dba8419d2b9e920403
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.