Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / packages / services / Car / 3c3216d85ade6d5db668c36fc48a6dd22fc393bb
commit3c3216d85ade6d5db668c36fc48a6dd22fc393bb[log] [tgz]
authorRam Periathiruvadi <ramperry@google.com>Tue Oct 15 18:01:12 2019 -0700
committerRam Periathiruvadi <ramperry@google.com>Tue Oct 15 18:06:47 2019 -0700
treeed41630160126ff56498533efd58f9b4f479a37d
parent54ba230d8d98b5b83c63a753ef254e6ce1efc03d [diff]
Fix concurrent modification exception.

The callbacks registered with the BlePeripheralManager were not
synchronized for thread safety.  Hence a BLE disconnect removed
listeners on one thread when data is still in transit on another thread
causing a concurrent modification exception.
Changing all callbacks and listeners to CopyOnWriteArrayList.

Bug: 141983882
Test: make and ensure Trusted device feature works.
Change-Id: Iaf04eb67f21d2581fbb6703e86efbcaa5c49e555
1 file changed
tree: ed41630160126ff56498533efd58f9b4f479a37d
  1. car-bugreportd/
  2. car-default-input-service/
  3. car-lib/
  4. car-maps-placeholder/
  5. car-systemtest-lib/
  6. car-test-lib/
  7. car-usb-handler/
  8. car_product/
  9. computepipe/
  10. EncryptionRunner/
  11. evs/
  12. FrameworkPackageStubs/
  13. obd2-lib/
  14. procfs-inspector/
  15. service/
  16. tests/
  17. tools/
  18. user/
  19. vehicle-hal-support-lib/
  20. .clang-format
  21. .gitignore
  22. Android.mk
  23. CleanSpec.mk
  24. OWNERS
  25. PREUPLOAD.cfg
  26. README.md
README.md

Native (C++) code format is required to be compatible with .clang-format file. Run

git clang-format --style=file --extension='h,cpp,cc' HEAD~

Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.