Improvements on VendorServiceControllerTest and CarUserNoticeServiceTest.

- Don't use MockitoJUnitRunner when calling session.initMocks().
- Use doReturn()/lambda when mocking static methods.
- Don't set non-trivial behavior on @Before method.
- Don't set redundant expectations (like methods that return false).
- Minor style issues.

Test: atest VendorServiceControllerTest CarUserNoticeServiceTest

Bug: 144732381
Bug: 152233130

Change-Id: Ia872751c00d810f1f3421c597da669a5e63b40e6
2 files changed
tree: 05a6dcecd06dee050b80f5856d7dde95d8753e0f
  1. car-bugreportd/
  2. car-default-input-service/
  3. car-lib/
  4. car-maps-placeholder/
  5. car-systemtest-lib/
  6. car-test-lib/
  7. car-usb-handler/
  8. car_product/
  9. computepipe/
  10. EncryptionRunner/
  11. evs/
  12. experimental/
  13. FrameworkPackageStubs/
  14. obd2-lib/
  15. procfs-inspector/
  16. service/
  17. surround_view/
  18. tests/
  19. tools/
  20. user/
  21. vehicle-hal-support-lib/
  22. watchdog/
  23. .clang-format
  24. .gitignore
  25. Android.mk
  26. CleanSpec.mk
  27. CPPLINT.cfg
  28. OWNERS
  29. PREUPLOAD.cfg
  30. README.md
README.md

Native (C++) code format is required to be compatible with .clang-format file. Run

git clang-format --style=file --extension='h,cpp,cc' HEAD~

Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.