Removes system-baseline.txt file and fixes the remaining warnings. Got a
green light from kwangsudo@ to remove the TODOs.
Bug: b/122836389, b/123093245
Fixes: b/122836389, b/123093245
Test: Refactoring CL. Existing tests are expected to pass.
Change-Id: I0b32baa13d310becd3e9210526685aecc10091b7
diff --git a/car-lib/api/current.txt b/car-lib/api/current.txt
index 30a5d1a..0d0ed45 100644
--- a/car-lib/api/current.txt
+++ b/car-lib/api/current.txt
@@ -441,6 +441,7 @@
field @Deprecated public static final int SENSOR_RATE_UI = 5; // 0x5
field @Deprecated public static final int SENSOR_TYPE_ABS_ACTIVE = 287310858; // 0x1120040a
field @Deprecated public static final int SENSOR_TYPE_CAR_SPEED = 291504647; // 0x11600207
+ field @Deprecated public static final int SENSOR_TYPE_ENGINE_OIL_LEVEL = 289407747; // 0x11400303
field @Deprecated public static final int SENSOR_TYPE_ENV_OUTSIDE_TEMPERATURE = 291505923; // 0x11600703
field @Deprecated public static final int SENSOR_TYPE_EV_BATTERY_CHARGE_RATE = 291504908; // 0x1160030c
field @Deprecated public static final int SENSOR_TYPE_EV_BATTERY_LEVEL = 291504905; // 0x11600309
diff --git a/car-lib/api/system-baseline.txt b/car-lib/api/system-baseline.txt
deleted file mode 100644
index ff683f6..0000000
--- a/car-lib/api/system-baseline.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-// Baseline format: 1.0
-
-HiddenTypedefConstant: android.car.CarInfoManager#getEvConnectorTypes():
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.EvConnectorType#UNKNOWN
-HiddenTypedefConstant: android.car.CarInfoManager#getFuelTypes():
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.FuelType#UNKNOWN
-HiddenTypedefConstant: android.car.hardware.CarPropertyValue#getStatus():
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarPropertyValue#STATUS_AVAILABLE
-HiddenTypedefConstant: android.car.hardware.CarSensorManager#getLatestSensorEvent(int) parameter #0:
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarSensorManager#SENSOR_TYPE_ENGINE_OIL_LEVEL
-HiddenTypedefConstant: android.car.hardware.CarSensorManager#isSensorSupported(int) parameter #0:
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarSensorManager#SENSOR_TYPE_ENGINE_OIL_LEVEL
-HiddenTypedefConstant: android.car.hardware.CarSensorManager#isSensorSupported(int[], int) parameter #1:
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarSensorManager#SENSOR_TYPE_ENGINE_OIL_LEVEL
-HiddenTypedefConstant: android.car.hardware.CarSensorManager#registerListener(android.car.hardware.CarSensorManager.OnSensorChangedListener, int, int) parameter #1:
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarSensorManager#SENSOR_TYPE_ENGINE_OIL_LEVEL
-HiddenTypedefConstant: android.car.hardware.CarSensorManager#unregisterListener(android.car.hardware.CarSensorManager.OnSensorChangedListener, int) parameter #1:
- Typedef references constant which isn't part of the API, skipping in documentation: android.car.hardware.CarSensorManager#SENSOR_TYPE_ENGINE_OIL_LEVEL
-
-
-RequiresPermission: android.car.hardware.CarSensorManager#registerListener(android.car.hardware.CarSensorManager.OnSensorChangedListener, int, int):
- Method 'registerListener' documentation mentions permissions already declared by @RequiresPermission
-
-
-SdkConstant: android.car.Car#CAR_INTENT_ACTION_MEDIA_TEMPLATE:
- Field 'CAR_INTENT_ACTION_MEDIA_TEMPLATE' is missing @SdkConstant(SdkConstantType.ACTIVITY_INTENT_ACTION)
-
-
-Todo: android.car.CarInfoManager#getVehicleId():
- Documentation mentions 'TODO'
-Todo: android.car.cluster.renderer.InstrumentClusterRenderer:
- Documentation mentions 'TODO'
-
diff --git a/car-lib/src/android/car/hardware/CarPropertyConfig.java b/car-lib/src/android/car/hardware/CarPropertyConfig.java
index 0f02fcd..6d44556 100644
--- a/car-lib/src/android/car/hardware/CarPropertyConfig.java
+++ b/car-lib/src/android/car/hardware/CarPropertyConfig.java
@@ -136,7 +136,6 @@
*
* @return Additional configuration parameters. For different properties, configArrays have
* different information.
- * TODO: b/128873196 need add link to document.
*/
@NonNull
public List<Integer> getConfigArray() {
diff --git a/car-lib/src/android/car/hardware/CarSensorManager.java b/car-lib/src/android/car/hardware/CarSensorManager.java
index 79a3086..d61cb2e 100644
--- a/car-lib/src/android/car/hardware/CarSensorManager.java
+++ b/car-lib/src/android/car/hardware/CarSensorManager.java
@@ -183,7 +183,6 @@
/**
* Oil level sensor.
* This requires {@link Car#PERMISSION_CAR_ENGINE_DETAILED} permission
- * @hide
*/
public static final int SENSOR_TYPE_ENGINE_OIL_LEVEL = 0x11400303;
@@ -380,19 +379,6 @@
* If the same listener is registered again for the same sensor, it will be either ignored or
* updated depending on the rate.
* <p>
- * Requires {@link Car#PERMISSION_SPEED} for {@link #SENSOR_TYPE_CAR_SPEED} and
- * {@link #SENSOR_TYPE_WHEEL_TICK_DISTANCE}, {@link Car#PERMISSION_CAR_ENGINE_DETAILED} for
- * {@link #SENSOR_TYPE_RPM} and {@link #SENSOR_TYPE_ENGINE_OIL_LEVEL},
- * {@link Car#PERMISSION_MILEAGE} for {@link #SENSOR_TYPE_ODOMETER},
- * {@link Car#PERMISSION_ENERGY} for {@link #SENSOR_TYPE_FUEL_LEVEL} and
- * {@link #SENSOR_TYPE_EV_BATTERY_LEVEL} and {@link #SENSOR_TYPE_EV_CHARGE_RATE},
- * {@link Car#PERMISSION_POWERTRAIN} for {@link #SENSOR_TYPE_PARKING_BRAKE} and
- * {@link #SENSOR_TYPE_GEAR} and {@link #SENSOR_TYPE_IGNITION_STATE},
- * {@link Car#PERMISSION_EXTERIOR_ENVIRONMENT} for {@link #SENSOR_TYPE_NIGHT} and
- * {@link #SENSOR_TYPE_ENV_OUTSIDE_TEMPERATURE}, {@link Car#PERMISSION_CAR_DYNAMICS_STATE} for
- * {@link #SENSOR_TYPE_ABS_ACTIVE} and {@link #SENSOR_TYPE_TRACTION_CONTROL_ACTIVE},
- * {@link Car#PERMISSION_ENERGY_PORTS} for {@link #SENSOR_TYPE_FUEL_DOOR_OPEN} and
- * {@link #SENSOR_TYPE_EV_CHARGE_PORT_OPEN} and {@link #SENSOR_TYPE_EV_CHARGE_PORT_CONNECTED}
*
* @param listener
* @param sensorType sensor type to subscribe.
diff --git a/car-lib/src/android/car/hardware/property/CarPropertyManager.java b/car-lib/src/android/car/hardware/property/CarPropertyManager.java
index a94e59f..d45ed3b 100644
--- a/car-lib/src/android/car/hardware/property/CarPropertyManager.java
+++ b/car-lib/src/android/car/hardware/property/CarPropertyManager.java
@@ -43,7 +43,6 @@
* Provides an application interface for interacting with the Vehicle specific properties.
* For details about the individual properties, see the descriptions in
* hardware/interfaces/automotive/vehicle/types.hal
- * TODO: b/128354867
*/
public class CarPropertyManager implements CarManagerBase {
private static final boolean DBG = false;