| commit | d24fcb2af082ff5ebf83f4d3e1f94769a8534d85 | [log] [tgz] |
|---|---|---|
| author | Changyeon Jo <changyeon@google.com> | Tue Jun 09 13:40:31 2020 -0700 |
| committer | Changyeon Jo <changyeon@google.com> | Tue Jun 09 13:48:22 2020 -0700 |
| tree | 646806c64d8383a410102b056d2998e9a4d1182d | |
| parent | 6559eb8637d50ebebf3aea19bb5c3ab4838ed1c9 [diff] |
Modifies HalCamera::clientStreamEnding() method
This change modifies a declaration of HalCamera::clientStreamEnding()
method to take a raw pointer of VirtualCamera object instead of its
smart pointer object. As this method is called from VirtualCamera
destructor, it causes a fatal error when a passed smart pointer object
is being destroyed at the end of the method.
Also, this change moves a line to clear a list of HalCamera objects in
VirtualCamera::shutdown(), to ensure it does not lose them during the
resource clean up.
Fix: 158339680
Test: Run /system/bin/evs_app in test mode w/ a logical camera device
and check there is no signal when it closes the device.
Change-Id: I0897bd7b55982f34162304d305e30666f3cb8b2f
Native (C++) code format is required to be compatible with .clang-format file. Run
git clang-format --style=file --extension='h,cpp,cc' HEAD~
Note that clang-format is not desirable for Android java files. Therefore the command line above is limited to specific extensions.