Add _UNSPECIFIED fields to enumss
Conform to best practices for protos and makes it possible to add new
fields in the future.
Test: No functionality changes
Change-Id: I698c7228d8622cd8c8b4628f603383ca181b0506
diff --git a/proto/telecom.proto b/proto/telecom.proto
index 06dd394..9fd64db 100644
--- a/proto/telecom.proto
+++ b/proto/telecom.proto
@@ -17,6 +17,7 @@
message LogSessionTiming {
enum SessionEntryPoint {
+ ENTRY_POINT_UNSPECIFIED = 0;
ICA_ANSWER_CALL = 1;
ICA_REJECT_CALL = 2;
ICA_DISCONNECT_CALL = 3;
@@ -46,6 +47,7 @@
message Event {
// From android.telecom.ParcelableAnalytics
enum EventName {
+ EVENT_NAME_UNSPECIFIED = 9999;
SET_SELECT_PHONE_ACCOUNT = 0;
SET_ACTIVE = 1;
SET_DISCONNECTED = 2;
@@ -100,6 +102,7 @@
message VideoEvent {
// From android.telecom.ParcelableCallAnalytics
enum VideoEventName {
+ VIDEO_EVENT_NAME_UNSPECIFIED = 9999;
SEND_LOCAL_SESSION_MODIFY_REQUEST = 0;
SEND_LOCAL_SESSION_MODIFY_RESPONSE = 1;
RECEIVE_REMOTE_SESSION_MODIFY_REQUEST = 2;
@@ -108,11 +111,12 @@
// From android.telecom.VideoProfile
enum VideoState {
- STATE_AUDIO_ONLY = 0;
- STATE_TX_ENABLED = 1;
- STATE_RX_ENABLED = 2;
- STATE_BIDIRECTIONAL = 3;
- STATE_PAUSED = 4;
+ // No unspecified field to define. This enum to be used only as values for a bitmask.
+ STATE_AUDIO_ONLY = 0;
+ STATE_TX_ENABLED = 1;
+ STATE_RX_ENABLED = 2;
+ STATE_BIDIRECTIONAL = 3;
+ STATE_PAUSED = 4;
}
// The ID of the event.
@@ -128,6 +132,7 @@
message EventTimingEntry {
enum EventTimingName {
+ EVENT_TIMING_NAME_UNSPECIFIED = 9999;
ACCEPT_TIMING = 0;
REJECT_TIMING = 1;
DISCONNECT_TIMING = 2;
@@ -152,6 +157,7 @@
message InCallServiceInfo {
// Keep this up-to-date with com.android.server.telecom.InCallController.
enum InCallServiceType {
+ IN_CALL_SERVICE_TYPE_UNSPECIFIED = 9999;
IN_CALL_SERVICE_TYPE_INVALID = 0;
IN_CALL_SERVICE_TYPE_DIALER_UI = 1;
IN_CALL_SERVICE_TYPE_SYSTEM_UI = 2;