commit | ef9e646f41b37a6d0f4a05a4411ef4bad2768cc9 | [log] [tgz] |
---|---|---|
author | Sam Saccone <samccone@google.com> | Fri Jul 10 16:41:52 2020 +0000 |
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | Fri Jul 10 16:41:52 2020 +0000 |
tree | 242c695e254ef9393678010544bf7cdfb32d0381 | |
parent | d4d07fb6648f5287dc255062f73fb15d1cc222fd [diff] | |
parent | 1eb168671507cbb94065e3da72b5d11e741cf5dc [diff] |
Handle case where checkstyle does not return 2 lines. am: 222ffec85d am: 2a0148feac am: 1eb1686715 Original change: https://android-review.googlesource.com/c/platform/prebuilts/checkstyle/+/1359805 Change-Id: Ic59ffa6a15064c5a10b4b3ace19a1e0ea8ecd242
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.