Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / bt / 26d45dc680f20b75fe04202c99a851eaf3832f2f
commit26d45dc680f20b75fe04202c99a851eaf3832f2f[log] [tgz]
authorJack He <siyuanh@google.com>Sun Jan 21 23:18:05 2018 -0800
committerJack He <siyuanh@google.com>Sun Jan 21 23:22:39 2018 -0800
treed7072bf597651851b111a1245ec277d26e3e0ca6
parent8b699d1076885c6525153d927a6edae2fa1ba6f0 [diff]
HFP: Do not use data in bta_ag_start_open if data is empty

* bta_ag_start_open() should not use data when data is empty

Change-Id: Id16d8c0ca90cbecb1b54900bd7f37a6c5c467ebd
Fixes: 72164296
Bug: 72164296
Test: make, pair and connect Bluetooth devices
2 files changed
tree: d7072bf597651851b111a1245ec277d26e3e0ca6
  1. audio_a2dp_hw/
  2. binder/
  3. bta/
  4. btcore/
  5. btif/
  6. build/
  7. conf/
  8. device/
  9. doc/
  10. embdrv/
  11. hci/
  12. include/
  13. internal_include/
  14. main/
  15. osi/
  16. service/
  17. stack/
  18. test/
  19. tools/
  20. types/
  21. udrv/
  22. utils/
  23. vendor_libs/
  24. vnd/
  25. .clang-format
  26. .gitignore
  27. .gn
  28. Android.bp
  29. Android.mk
  30. BUILD.gn
  31. CleanSpec.mk
  32. EventLogTags.logtags
  33. MODULE_LICENSE_APACHE2
  34. NOTICE
  35. OWNERS
  36. PREUPLOAD.cfg
  37. README.md
README.md

Fluoride Bluetooth stack

Building and running on AOSP

Just build AOSP - Fluoride is there by default.

Building and running on Linux

Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0

Download source

mkdir ~/fluoride
cd ~/fluoride
git clone https://android.googlesource.com/platform/system/bt

Install dependencies (require sudo access):

cd ~/fluoride/bt
build/install_deps.sh

Then fetch third party dependencies:

cd ~/fluoride/bt
mkdir third_party
cd third_party
git clone https://github.com/google/googletest.git
git clone https://android.googlesource.com/platform/external/aac
git clone https://android.googlesource.com/platform/external/libchrome
git clone https://android.googlesource.com/platform/external/libldac
git clone https://android.googlesource.com/platform/external/modp_b64
git clone https://android.googlesource.com/platform/external/tinyxml2

And third party dependencies of third party dependencies:

cd fluoride/bt/third_party/libchrome/base/third_party
mkdir valgrind
cd valgrind
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h

NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources

cd system/bt
mkdir third_party
cd third_party
ln -s ../../../external/aac aac
ln -s ../../../external/libchrome libchrome
ln -s ../../../external/libldac libldac
ln -s ../../../external/modp_b64 modp_b64
ln -s ../../../external/tinyxml2 tinyxml2
ln -s ../../../external/googletest googletest

Generate your build files

cd ~/fluoride/bt
gn gen out/Default

Build

cd ~/fluoride/bt
ninja -C out/Default all

This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.

Run

cd ~/fluoride/bt/out/Default
LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride

Eclipse IDE Support

  1. Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)

  2. Generate Eclipse settings:

cd system/bt
gn gen --ide=eclipse out/Default

  1. In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default

  2. Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"

  3. Goto Behaviour tab, change clean command to "-t clean"