| commit | 625f798c696229b0cc58e5f85409fd029f987473 | [log] [tgz] |
|---|---|---|
| author | Timm Korte <timm.korte@gmail.com> | Mon May 15 08:30:00 2017 +0200 |
| committer | Andre Eisenbach <eisenbach@google.com> | Wed Jul 12 22:25:05 2017 +0000 |
| tree | 910d31600cbc4ac7befab86342f8b6d3d67c19b9 | |
| parent | 2dd6b59d57a11577f42831c23e72612b55a3f814 [diff] |
bt: fix sdp service name by removing NULL char The Bluedroid stack uses a C string with terminating NULL char as a service name. Since in BT, strings are TLV encoded (type, length, value), this doesn't make sense. Simple fix is to copy the string without the trailing NULL by removing the "+1" after the strlen call when passing the string as uint8_t array to the lower level functions. The current behaviour keeps some older devices from being able to connect to an Android providing a Serial Port profile due to having the wrong service name (that is, including a NULL at the end instead of the correct string). Test: Checked against Linux BlueZ, which does not include this extra null character. Change-Id: I6a43024ff89ac09e4b2d2e5cfb407b6e9323f0bd Signed-off-by: Timm Korte <timm.korte@gmail.com>
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2 git clone https://android.googlesource.com/platform/hardware/libhardware
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources
cd system/bt mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../hardware/libhardware libhardware ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd system/bt gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"