Gitiles
Code Review Sign In
gerrit-public.fairphone.software / platform / system / bt / 541862ce72d4203f015acb0956541767fa2470f1
commit541862ce72d4203f015acb0956541767fa2470f1[log] [tgz]
authorJakub Pawlowski <jpawlowski@google.com>Wed Feb 07 11:37:18 2018 -0800
committerJakub Pawlowski <jpawlowski@google.com>Wed Feb 07 20:48:17 2018 +0000
tree01457a18ed76a22b7d9fe7264f1df3abd285640f
parent0c0d2975d752289f53bf18a4b74c94b2f74c1235 [diff]
Call BTA_GATTS_AddService on correct thread

Right now BTA_GATTS_AddService is incorrectly called on btif thread.
This might lead to situations where it is executed while bta thread is
already cleaning up, and deleted the control blocks, resulting in crashes.
From now on, execute it on bta thread. This ensures that it is executed
before control blocks are freed.

Test: sl4a GattClientTest
Bug: 73054849
Change-Id: Ie2bf80414bceba2590c21d3825c78fbb58449520
3 files changed
tree: 01457a18ed76a22b7d9fe7264f1df3abd285640f
  1. audio_a2dp_hw/
  2. binder/
  3. bta/
  4. btcore/
  5. btif/
  6. build/
  7. conf/
  8. device/
  9. doc/
  10. embdrv/
  11. hci/
  12. include/
  13. internal_include/
  14. main/
  15. osi/
  16. packet/
  17. service/
  18. stack/
  19. test/
  20. tools/
  21. types/
  22. udrv/
  23. utils/
  24. vendor_libs/
  25. vnd/
  26. .clang-format
  27. .gitignore
  28. .gn
  29. Android.bp
  30. Android.mk
  31. BUILD.gn
  32. CleanSpec.mk
  33. EventLogTags.logtags
  34. MODULE_LICENSE_APACHE2
  35. NOTICE
  36. OWNERS
  37. PREUPLOAD.cfg
  38. README.md
README.md

Fluoride Bluetooth stack

Building and running on AOSP

Just build AOSP - Fluoride is there by default.

Building and running on Linux

Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0

Download source

mkdir ~/fluoride
cd ~/fluoride
git clone https://android.googlesource.com/platform/system/bt

Install dependencies (require sudo access):

cd ~/fluoride/bt
build/install_deps.sh

Then fetch third party dependencies:

cd ~/fluoride/bt
mkdir third_party
cd third_party
git clone https://github.com/google/googletest.git
git clone https://android.googlesource.com/platform/external/aac
git clone https://android.googlesource.com/platform/external/libchrome
git clone https://android.googlesource.com/platform/external/libldac
git clone https://android.googlesource.com/platform/external/modp_b64
git clone https://android.googlesource.com/platform/external/tinyxml2

And third party dependencies of third party dependencies:

cd fluoride/bt/third_party/libchrome/base/third_party
mkdir valgrind
cd valgrind
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h
curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h

NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources

cd system/bt
mkdir third_party
cd third_party
ln -s ../../../external/aac aac
ln -s ../../../external/libchrome libchrome
ln -s ../../../external/libldac libldac
ln -s ../../../external/modp_b64 modp_b64
ln -s ../../../external/tinyxml2 tinyxml2
ln -s ../../../external/googletest googletest

Generate your build files

cd ~/fluoride/bt
gn gen out/Default

Build

cd ~/fluoride/bt
ninja -C out/Default all

This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi.

Run

cd ~/fluoride/bt/out/Default
LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride

Eclipse IDE Support

  1. Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)

  2. Generate Eclipse settings:

cd system/bt
gn gen --ide=eclipse out/Default

  1. In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default

  2. Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"

  3. Goto Behaviour tab, change clean command to "-t clean"