commit | 6545d3f346764d796db65f403335f0d2e83ea35a | [log] [tgz] |
---|---|---|
author | Jack He <siyuanh@google.com> | Mon Dec 11 19:49:30 2017 -0800 |
committer | Jack He <siyuanh@google.com> | Thu Dec 14 00:10:11 2017 +0000 |
tree | eb77d40b1f5260d9982b6993c8d885100887c866 | |
parent | 4edb5857bcfd87273d45a74ce246216dd1537bfe [diff] |
HFP: Fix static check errors * In bta/ag and btif/btif_hf.cc * Simplify boolean values * Use nullptr intead of NULL * Use C++ style include headers instead of C style ones * Remove unused struct definitions * Remove unused code from bta_ag_ci.h/cc * Use range based for-loop when it can be converted automatically * Use C++ style zero-initialization instead of memset so that non-POD members of structs can be initialized properly * Use "" to initliaze char array since the rest of the array will be zero padded if the array is assigned to a shorter string than its length Bug: 68340193 Test: make, connect to HFP enabled device Change-Id: I25c1e48ca1cb40629b9b60243ec462f498d8fc24
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources
cd system/bt mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd system/bt gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"