commit | bc9a9329b3b814e85b64e6939e58e6af9990e681 | [log] [tgz] |
---|---|---|
author | Pavlin Radoslavov <pavlin@google.com> | Thu Mar 16 04:54:21 2017 -0700 |
committer | Pavlin Radoslavov <pavlin@google.com> | Thu Mar 16 12:30:41 2017 -0700 |
tree | 877ee3aec8a787462aa6c046d21a1b06ec7d4da5 | |
parent | 01ce9e4233561dc55e05389959ad9d5a5db25d44 [diff] |
Fix an HCI race condition when transmitting a packet There is a race condition when calling event_command_ready() -> transmit_fragment() -> hci_transmit() If right after hci_transmit() there is thread context switch and another thread executes filter_incoming_event() for the same command, the corresponding packet/command will be taken off the commands_pending_response list and free()-ed. However, after the execution on the first thread continues within transmit_fragment(), the execution logic will continue using the "packet" that was already free()-ed by the other thread. To prevent this from happening, the "commands_pending_response_mutex" within event_command_ready() has to protect the transmit_fragment() execution and the update_command_response_timer() function right after it. Also: * Changed the "commands_pending_response_mutex" to recursive_mutex * Added "commands_pending_response_mutex" protection in few other places where "commands_pending_response" itself is used. Bug: 36205494 Test: Running ASAN build Change-Id: I63677ad1f2b28683c321631e9e29e4f01628d269
Just build AOSP - Fluoride is there by default.
Instructions for Ubuntu, tested on 14.04 with Clang 3.5.0 and 16.10 with Clang 3.8.0
mkdir ~/fluoride cd ~/fluoride git clone https://android.googlesource.com/platform/system/bt
Install dependencies (require sudo access):
cd ~/fluoride/bt build/install_deps.sh
Then fetch third party dependencies:
cd ~/fluoride/bt mkdir third_party cd third_party git clone https://github.com/google/googletest.git git clone https://android.googlesource.com/platform/external/aac git clone https://android.googlesource.com/platform/external/libchrome git clone https://android.googlesource.com/platform/external/libldac git clone https://android.googlesource.com/platform/external/modp_b64 git clone https://android.googlesource.com/platform/external/tinyxml2 git clone https://android.googlesource.com/platform/hardware/libhardware
And third party dependencies of third party dependencies:
cd fluoride/bt/third_party/libchrome/base/third_party mkdir valgrind cd valgrind curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/valgrind.h?format=TEXT | base64 -d > valgrind.h curl https://chromium.googlesource.com/chromium/src/base/+/master/third_party/valgrind/memcheck.h?format=TEXT | base64 -d > memcheck.h
NOTE: If system/bt is checked out under AOSP, then create symbolic links instead of downloading sources
cd system/bt mkdir third_party cd third_party ln -s ../../../external/aac aac ln -s ../../../external/libchrome libchrome ln -s ../../../external/libldac libldac ln -s ../../../external/modp_b64 modp_b64 ln -s ../../../external/tinyxml2 tinyxml2 ln -s ../../../hardware/libhardware libhardware ln -s ../../../external/googletest googletest
cd ~/fluoride/bt gn gen out/Default
cd ~/fluoride/bt ninja -C out/Default all
This will build all targets (the shared library, executables, tests, etc) and put them in out/Default. To build an individual target, replace "all" with the target of your choice, e.g. ninja -C out/Default net_test_osi
.
cd ~/fluoride/bt/out/Default LD_LIBRARY_PATH=./ ./bluetoothtbd -create-ipc-socket=fluoride
Follows the Chromium project Eclipse Setup Instructions until "Optional: Building inside Eclipse" section (don't do that section, we will set it up differently)
Generate Eclipse settings:
cd system/bt gn gen --ide=eclipse out/Default
In Eclipse, do File->Import->C/C++->C/C++ Project Settings, choose the XML location under system/bt/out/Default
Right click on the project. Go to Preferences->C/C++ Build->Builder Settings. Uncheck "Use default build command", but instead using "ninja -C out/Default"
Goto Behaviour tab, change clean command to "-t clean"