tree 1bde3615b6be448a0e6668f91d23dea3b504f71a
parent 221e9bf6c9e9f974efd92ea4f054dbdba248d2db
author Jack He <siyuanh@google.com> 1481623152 -0800
committer Jack He <siyuanh@google.com> 1481872089 -0800

Replace assert with CHECK from base/logging.h

* Replace assert with CHECK
* Remove all NDEBUG definitions
* Remove hacks for BT_LIBCHROME_NDEBUG
* Removed some removed directories from Makefile such as hcis, brcm, rpc

Coccinelle-assisted:

@@
@@

- #include "base/logging.h"
+ #include <base/logging.h>

@ assert_included @
@@

@ base_logging_included @
@@

@ depends on (assert_included && !(base_logging_included)) @
@@

- #include <assert.h>
+ #include <base/logging.h>

@ depends on (assert_included && base_logging_included) @
@@

- #include <assert.h>

@@
expression E;
@@

- assert(E);
+ CHECK(E);

And a bash script:

for file in $(find . -name "*.cc"); do
  spatch --sp-file replace_assert_with_CHECK.cocci --in-place $file
done

The following files are maually edited:
	btif/src/btif_config.cc
	btif/src/btif_avrcp_audio_track.cc
	btif/src/btif_gatt_client.cc
	osi/src/data_dispatcher.cc
	osi/src/reactor.cc
	osi/src/thread.cc
	osi/src/fixed_queue.cc
	osi/src/list.cc
	osi/src/allocation_tracker.cc
	osi/src/alarm.cc
	osi/test/wakelock_test.cc

Bug: 31781465
Test: Code compilation, Unit Tests, BtStressTest, BtFunhausMetricsTest
Change-Id: I21dc10a45be31665e41441b75b0515ed87523988