commit 00917ceafbc28599391bfcdd5837faf6d63fec32
author mukesh agrawal <quiche@chromium.org> Tue Nov 22 23:56:55 2011 +0000
committer mukesh agrawal <quiche@chromium.org> Wed Nov 23 14:32:25 2011 -0800
tree 345e57fd7fe7074bb5ba0c8d5b1409e9de1f0c38
parent b72cf40dc315f9ae3537980f4fd85e737c125a03

shill: set favorite property when a Service is connected, and
set autoconnect property when a Service is made a favorite

BUG=chromium-os:23346,chromium-os:23349
TEST=new unittests

Bonus changes:
- remove some unused variables in ManagerTest.SortServices
- add "static" comment for Service::DecideBetween and
  Service::Compare

Change-Id: I4b7e01f98d1292b9c8f951c9a54a01f76292b740
Reviewed-on: https://gerrit.chromium.org/gerrit/12053
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>

wifi_unittest.cc

diff --git a/wifi_unittest.cc b/wifi_unittest.cc
index 11f7c9a..3b97b7e 100644
--- a/wifi_unittest.cc
+++ b/wifi_unittest.cc
@@ -854,7 +854,7 @@
                         NULL, NULL, true, &e);
     EXPECT_TRUE(e.IsSuccess());
     EXPECT_TRUE(service->hidden_ssid());
-    service->set_favorite(true);
+    service->MakeFavorite();
   }
   {
     // Create a hidden, non-favorite service.
@@ -873,7 +873,7 @@
                         NULL, NULL, false, &e);
     EXPECT_TRUE(e.IsSuccess());
     EXPECT_FALSE(service->hidden_ssid());
-    service->set_favorite(true);
+    service->MakeFavorite();
   }
   EXPECT_CALL(*supplicant_interface_proxy_, Scan(HasHiddenSSID("ssid0")));
   StartWiFi();