commit | 033e2fabdace760fad92e0b227fcfbd58024176e | [log] [tgz] |
---|---|---|
author | Julius Werner <jwerner@chromium.org> | Thu Nov 15 21:37:19 2012 -0800 |
committer | Gerrit <chrome-bot@google.com> | Fri Nov 16 11:24:55 2012 -0800 |
tree | 0cd67f9cabe0cf452c581cc0b6a1b0e39881e610 | |
parent | 6999022029507e90bc8a032b85e87ef83d2c4d1d [diff] |
shill: Make errors on a GLib IOChannel fail on read() instead of poll() GLib IO channel handlers are entered with the condition G_IO_ERR ( == POLLERR) when the monitored file descriptor encounters an error condition. However, just like with a regular poll(), the socket's actual error number is not communicated by that and must be read explicitly. It is therefore not useful for debugging to immediately die when seeing a G_IO_ERR condition. This patch changes the respective fatal error messages to warnings, so that execution may continue in the same way it would on a normal G_IO_IN ( == POLLIN). This will ultimately lead to a read() or similar call on the file descriptor, which should then fail with a more useful error message that includes the socket's error number. BUG=chromium-os:36328 TEST=None Change-Id: If8bba9990b836546dc17d92bfd51cb47ea02d518 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://gerrit.chromium.org/gerrit/38182 Reviewed-by: mukesh agrawal <quiche@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org>