shill: reduce logspam due to autoconnect

It's quite normal, and frequent, for an autoconnect request
(from the Manager, to a Service), to be supressed because
  a) we're already connected to that Service, or
  b) the Device needed by this Service is busy.

Reduce log-spam by logging those cases with SLOG at level 1,
rather than at LOG_INFO.

Checking a couple of the log files on one of my Chromebooks,
this would reduce the number of shill log lines by 7-8%.

While there: consolidate the kAutoConnConnected string into
Service. (It was previously defined independently in WiFiService
and WiMaxService.)

BUG=chromium-os:31143
TEST=unit tests

Change-Id: Ifc94e1357674999e65eb7b3ec98f6381ea59fc0d
Reviewed-on: https://gerrit.chromium.org/gerrit/38974
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
7 files changed
tree: e44815bc39dff518747880c44cdf441abd8b0ac7
  1. bin/
  2. data/
  3. dbus_bindings/
  4. doc/
  5. shims/
  6. .gitignore
  7. accessor_interface.h
  8. adaptor_interfaces.h
  9. arp_client.cc
  10. arp_client.h
  11. arp_client_unittest.cc
  12. arp_packet.cc
  13. arp_packet.h
  14. arp_packet_unittest.cc
  15. async_connection.cc
  16. async_connection.h
  17. async_connection_unittest.cc
  18. byte_string.cc
  19. byte_string.h
  20. byte_string_unittest.cc
  21. callback80211_metrics.cc
  22. callback80211_metrics.h
  23. callback80211_object.cc
  24. callback80211_object.h
  25. callbacks.h
  26. cellular.cc
  27. cellular.h
  28. cellular_capability.cc
  29. cellular_capability.h
  30. cellular_capability_cdma.cc
  31. cellular_capability_cdma.h
  32. cellular_capability_cdma_unittest.cc
  33. cellular_capability_classic.cc
  34. cellular_capability_classic.h
  35. cellular_capability_classic_unittest.cc
  36. cellular_capability_gsm.cc
  37. cellular_capability_gsm.h
  38. cellular_capability_gsm_unittest.cc
  39. cellular_capability_universal.cc
  40. cellular_capability_universal.h
  41. cellular_capability_universal_unittest.cc
  42. cellular_error.cc
  43. cellular_error.h
  44. cellular_operator_info.cc
  45. cellular_operator_info.h
  46. cellular_operator_info_unittest.cc
  47. cellular_service.cc
  48. cellular_service.h
  49. cellular_service_unittest.cc
  50. cellular_unittest.cc
  51. config80211.cc
  52. config80211.h
  53. config80211_unittest.cc
  54. connection.cc
  55. connection.h
  56. connection_unittest.cc
  57. control_interface.h
  58. crypto_des_cbc.cc
  59. crypto_des_cbc.h
  60. crypto_des_cbc_unittest.cc
  61. crypto_interface.h
  62. crypto_provider.cc
  63. crypto_provider.h
  64. crypto_provider_unittest.cc
  65. crypto_rot47.cc
  66. crypto_rot47.h
  67. crypto_rot47_unittest.cc
  68. dbus_adaptor.cc
  69. dbus_adaptor.h
  70. dbus_adaptor_unittest.cc
  71. dbus_control.cc
  72. dbus_control.h
  73. dbus_manager.cc
  74. dbus_manager.h
  75. dbus_manager_unittest.cc
  76. dbus_objectmanager_proxy.cc
  77. dbus_objectmanager_proxy.h
  78. dbus_objectmanager_proxy_interface.h
  79. dbus_properties.cc
  80. dbus_properties.h
  81. dbus_properties_proxy.cc
  82. dbus_properties_proxy.h
  83. dbus_properties_proxy_interface.h
  84. dbus_properties_unittest.cc
  85. dbus_property_matchers.h
  86. dbus_service_proxy.cc
  87. dbus_service_proxy.h
  88. dbus_service_proxy_interface.h
  89. default_profile.cc
  90. default_profile.h
  91. default_profile_unittest.cc
  92. device.cc
  93. device.h
  94. device_dbus_adaptor.cc
  95. device_dbus_adaptor.h
  96. device_info.cc
  97. device_info.h
  98. device_info_unittest.cc
  99. device_stub.h
  100. device_unittest.cc
  101. dhcp_config.cc
  102. dhcp_config.h
  103. dhcp_config_unittest.cc
  104. dhcp_provider.cc
  105. dhcp_provider.h
  106. dhcp_provider_unittest.cc
  107. dhcp_proxy_interface.h
  108. dhcpcd_proxy.cc
  109. dhcpcd_proxy.h
  110. diagnostics_reporter.cc
  111. diagnostics_reporter.h
  112. diagnostics_reporter_unittest.cc
  113. dns_client.cc
  114. dns_client.h
  115. dns_client_unittest.cc
  116. endpoint.cc
  117. endpoint.h
  118. ephemeral_profile.cc
  119. ephemeral_profile.h
  120. error.cc
  121. error.h
  122. error_unittest.cc
  123. ethernet.cc
  124. ethernet.h
  125. ethernet_service.cc
  126. ethernet_service.h
  127. ethernet_service_unittest.cc
  128. event_dispatcher.cc
  129. event_dispatcher.h
  130. geolocation_info.cc
  131. geolocation_info.h
  132. glib.cc
  133. glib.h
  134. glib_io_input_handler.cc
  135. glib_io_input_handler.h
  136. glib_io_ready_handler.cc
  137. glib_io_ready_handler.h
  138. HACKING
  139. hook_table.cc
  140. hook_table.h
  141. hook_table_unittest.cc
  142. http_proxy.cc
  143. http_proxy.h
  144. http_proxy_unittest.cc
  145. http_request.cc
  146. http_request.h
  147. http_request_unittest.cc
  148. http_url.cc
  149. http_url.h
  150. http_url_unittest.cc
  151. ieee80211.h
  152. io_handler.h
  153. ip_address.cc
  154. ip_address.h
  155. ip_address_unittest.cc
  156. ipconfig.cc
  157. ipconfig.h
  158. ipconfig_dbus_adaptor.cc
  159. ipconfig_dbus_adaptor.h
  160. ipconfig_unittest.cc
  161. kernel_bound_nlmessage.cc
  162. kernel_bound_nlmessage.h
  163. key_file_store.cc
  164. key_file_store.h
  165. key_file_store_unittest.cc
  166. key_value_store.cc
  167. key_value_store.h
  168. key_value_store_matcher.h
  169. key_value_store_unittest.cc
  170. l2tp_ipsec_driver.cc
  171. l2tp_ipsec_driver.h
  172. l2tp_ipsec_driver_unittest.cc
  173. LICENSE
  174. link_monitor.cc
  175. link_monitor.h
  176. link_monitor_unittest.cc
  177. logging.h
  178. Makefile
  179. manager.cc
  180. manager.h
  181. manager_dbus_adaptor.cc
  182. manager_dbus_adaptor.h
  183. manager_unittest.cc
  184. memory_log.cc
  185. memory_log.h
  186. memory_log_unittest.cc
  187. metrics.cc
  188. metrics.h
  189. metrics_unittest.cc
  190. minijail.cc
  191. minijail.h
  192. mm1_bearer_proxy.cc
  193. mm1_bearer_proxy.h
  194. mm1_bearer_proxy_interface.h
  195. mm1_modem_modem3gpp_proxy.cc
  196. mm1_modem_modem3gpp_proxy.h
  197. mm1_modem_modem3gpp_proxy_interface.h
  198. mm1_modem_modemcdma_proxy.cc
  199. mm1_modem_modemcdma_proxy.h
  200. mm1_modem_modemcdma_proxy_interface.h
  201. mm1_modem_proxy.cc
  202. mm1_modem_proxy.h
  203. mm1_modem_proxy_interface.h
  204. mm1_modem_simple_proxy.cc
  205. mm1_modem_simple_proxy.h
  206. mm1_modem_simple_proxy_interface.h
  207. mm1_sim_proxy.cc
  208. mm1_sim_proxy.h
  209. mm1_sim_proxy_interface.h
  210. mock_adaptors.cc
  211. mock_adaptors.h
  212. mock_ares.cc
  213. mock_ares.h
  214. mock_arp_client.cc
  215. mock_arp_client.h
  216. mock_async_connection.cc
  217. mock_async_connection.h
  218. mock_callback80211_object.h
  219. mock_cellular.cc
  220. mock_cellular.h
  221. mock_cellular_operator_info.cc
  222. mock_cellular_operator_info.h
  223. mock_cellular_service.cc
  224. mock_cellular_service.h
  225. mock_connection.cc
  226. mock_connection.h
  227. mock_control.cc
  228. mock_control.h
  229. mock_dbus_manager.cc
  230. mock_dbus_manager.h
  231. mock_dbus_objectmanager_proxy.cc
  232. mock_dbus_objectmanager_proxy.h
  233. mock_dbus_properties_proxy.cc
  234. mock_dbus_properties_proxy.h
  235. mock_dbus_service_proxy.cc
  236. mock_dbus_service_proxy.h
  237. mock_device.cc
  238. mock_device.h
  239. mock_device_info.cc
  240. mock_device_info.h
  241. mock_dhcp_config.cc
  242. mock_dhcp_config.h
  243. mock_dhcp_provider.cc
  244. mock_dhcp_provider.h
  245. mock_dhcp_proxy.cc
  246. mock_dhcp_proxy.h
  247. mock_dns_client.cc
  248. mock_dns_client.h
  249. mock_ethernet.cc
  250. mock_ethernet.h
  251. mock_event_dispatcher.cc
  252. mock_event_dispatcher.h
  253. mock_glib.cc
  254. mock_glib.h
  255. mock_http_request.cc
  256. mock_http_request.h
  257. mock_ipconfig.cc
  258. mock_ipconfig.h
  259. mock_link_monitor.cc
  260. mock_link_monitor.h
  261. mock_log.cc
  262. mock_log.h
  263. mock_log_unittest.cc
  264. mock_manager.cc
  265. mock_manager.h
  266. mock_metrics.cc
  267. mock_metrics.h
  268. mock_minijail.cc
  269. mock_minijail.h
  270. mock_mm1_bearer_proxy.cc
  271. mock_mm1_bearer_proxy.h
  272. mock_mm1_modem_modem3gpp_proxy.cc
  273. mock_mm1_modem_modem3gpp_proxy.h
  274. mock_mm1_modem_modemcdma_proxy.cc
  275. mock_mm1_modem_modemcdma_proxy.h
  276. mock_mm1_modem_proxy.cc
  277. mock_mm1_modem_proxy.h
  278. mock_mm1_modem_simple_proxy.cc
  279. mock_mm1_modem_simple_proxy.h
  280. mock_mm1_sim_proxy.cc
  281. mock_mm1_sim_proxy.h
  282. mock_modem.cc
  283. mock_modem.h
  284. mock_modem_cdma_proxy.cc
  285. mock_modem_cdma_proxy.h
  286. mock_modem_gobi_proxy.cc
  287. mock_modem_gobi_proxy.h
  288. mock_modem_gsm_card_proxy.cc
  289. mock_modem_gsm_card_proxy.h
  290. mock_modem_gsm_network_proxy.cc
  291. mock_modem_gsm_network_proxy.h
  292. mock_modem_info.cc
  293. mock_modem_info.h
  294. mock_modem_manager_proxy.cc
  295. mock_modem_manager_proxy.h
  296. mock_modem_proxy.cc
  297. mock_modem_proxy.h
  298. mock_modem_simple_proxy.cc
  299. mock_modem_simple_proxy.h
  300. mock_nl80211_socket.h
  301. mock_nss.cc
  302. mock_nss.h
  303. mock_openvpn_driver.cc
  304. mock_openvpn_driver.h
  305. mock_openvpn_management_server.cc
  306. mock_openvpn_management_server.h
  307. mock_portal_detector.cc
  308. mock_portal_detector.h
  309. mock_power_manager.cc
  310. mock_power_manager.h
  311. mock_power_manager_proxy.cc
  312. mock_power_manager_proxy.h
  313. mock_process_killer.cc
  314. mock_process_killer.h
  315. mock_profile.cc
  316. mock_profile.h
  317. mock_property_store.cc
  318. mock_property_store.h
  319. mock_proxy_factory.cc
  320. mock_proxy_factory.h
  321. mock_resolver.cc
  322. mock_resolver.h
  323. mock_routing_table.cc
  324. mock_routing_table.h
  325. mock_rtnl_handler.cc
  326. mock_rtnl_handler.h
  327. mock_service.cc
  328. mock_service.h
  329. mock_sockets.cc
  330. mock_sockets.h
  331. mock_store.cc
  332. mock_store.h
  333. mock_supplicant_bss_proxy.cc
  334. mock_supplicant_bss_proxy.h
  335. mock_supplicant_interface_proxy.cc
  336. mock_supplicant_interface_proxy.h
  337. mock_supplicant_process_proxy.cc
  338. mock_supplicant_process_proxy.h
  339. mock_time.cc
  340. mock_time.h
  341. mock_vpn.cc
  342. mock_vpn.h
  343. mock_vpn_driver.cc
  344. mock_vpn_driver.h
  345. mock_vpn_provider.cc
  346. mock_vpn_provider.h
  347. mock_vpn_service.cc
  348. mock_vpn_service.h
  349. mock_wifi.cc
  350. mock_wifi.h
  351. mock_wifi_service.cc
  352. mock_wifi_service.h
  353. mock_wimax.cc
  354. mock_wimax.h
  355. mock_wimax_device_proxy.cc
  356. mock_wimax_device_proxy.h
  357. mock_wimax_manager_proxy.cc
  358. mock_wimax_manager_proxy.h
  359. mock_wimax_network_proxy.cc
  360. mock_wimax_network_proxy.h
  361. mock_wimax_provider.cc
  362. mock_wimax_provider.h
  363. mock_wimax_service.cc
  364. mock_wimax_service.h
  365. modem.cc
  366. modem.h
  367. modem_1.cc
  368. modem_1_unittest.cc
  369. modem_cdma_proxy.cc
  370. modem_cdma_proxy.h
  371. modem_cdma_proxy_interface.h
  372. modem_classic.cc
  373. modem_gobi_proxy.cc
  374. modem_gobi_proxy.h
  375. modem_gobi_proxy_interface.h
  376. modem_gsm_card_proxy.cc
  377. modem_gsm_card_proxy.h
  378. modem_gsm_card_proxy_interface.h
  379. modem_gsm_network_proxy.cc
  380. modem_gsm_network_proxy.h
  381. modem_gsm_network_proxy_interface.h
  382. modem_info.cc
  383. modem_info.h
  384. modem_info_unittest.cc
  385. modem_manager.cc
  386. modem_manager.h
  387. modem_manager_1.cc
  388. modem_manager_proxy.cc
  389. modem_manager_proxy.h
  390. modem_manager_proxy_interface.h
  391. modem_manager_unittest.cc
  392. modem_proxy.cc
  393. modem_proxy.h
  394. modem_proxy_interface.h
  395. modem_simple_proxy.cc
  396. modem_simple_proxy.h
  397. modem_simple_proxy_interface.h
  398. modem_unittest.cc
  399. netlink_socket.cc
  400. netlink_socket.h
  401. nice_mock_control.cc
  402. nice_mock_control.h
  403. nl80211_socket.cc
  404. nl80211_socket.h
  405. nss.cc
  406. nss.h
  407. nss_unittest.cc
  408. openvpn_driver.cc
  409. openvpn_driver.h
  410. openvpn_driver_unittest.cc
  411. openvpn_management_server.cc
  412. openvpn_management_server.h
  413. openvpn_management_server_unittest.cc
  414. portal_detector.cc
  415. portal_detector.h
  416. portal_detector_unittest.cc
  417. power_manager.cc
  418. power_manager.h
  419. power_manager_proxy.cc
  420. power_manager_proxy.h
  421. power_manager_proxy_interface.h
  422. power_manager_unittest.cc
  423. process_killer.cc
  424. process_killer.h
  425. process_killer_unittest.cc
  426. profile.cc
  427. profile.h
  428. profile_dbus_adaptor.cc
  429. profile_dbus_adaptor.h
  430. profile_dbus_property_exporter.cc
  431. profile_dbus_property_exporter.h
  432. profile_dbus_property_exporter_unittest.cc
  433. profile_unittest.cc
  434. property_accessor.h
  435. property_accessor_unittest.cc
  436. property_iterator.h
  437. property_store.cc
  438. property_store.h
  439. property_store_inspector.cc
  440. property_store_inspector.h
  441. property_store_unittest.cc
  442. property_store_unittest.h
  443. provider_db_unittest.bfd
  444. proxy_factory.cc
  445. proxy_factory.h
  446. refptr_types.h
  447. resolver.cc
  448. resolver.h
  449. resolver_unittest.cc
  450. routing_table.cc
  451. routing_table.h
  452. routing_table_entry.h
  453. routing_table_unittest.cc
  454. rpc_task.cc
  455. rpc_task.h
  456. rpc_task_dbus_adaptor.cc
  457. rpc_task_dbus_adaptor.h
  458. rpc_task_unittest.cc
  459. rtnl_handler.cc
  460. rtnl_handler.h
  461. rtnl_handler_unittest.cc
  462. rtnl_listener.cc
  463. rtnl_listener.h
  464. rtnl_listener_unittest.cc
  465. rtnl_message.cc
  466. rtnl_message.h
  467. rtnl_message_unittest.cc
  468. scope_logger.cc
  469. scope_logger.h
  470. scope_logger_unittest.cc
  471. service.cc
  472. service.h
  473. service_dbus_adaptor.cc
  474. service_dbus_adaptor.h
  475. service_sorter.h
  476. service_under_test.cc
  477. service_under_test.h
  478. service_unittest.cc
  479. shill_ares.cc
  480. shill_ares.h
  481. shill_config.cc
  482. shill_config.h
  483. shill_daemon.cc
  484. shill_daemon.h
  485. shill_main.cc
  486. shill_test_config.cc
  487. shill_test_config.h
  488. shill_time.cc
  489. shill_time.h
  490. shill_unittest.cc
  491. sockets.cc
  492. sockets.h
  493. static_ip_parameters.cc
  494. static_ip_parameters.h
  495. static_ip_parameters_unittest.cc
  496. store_interface.h
  497. supplicant_bss_proxy.cc
  498. supplicant_bss_proxy.h
  499. supplicant_bss_proxy_interface.h
  500. supplicant_interface_proxy.cc
  501. supplicant_interface_proxy.h
  502. supplicant_interface_proxy_interface.h
  503. supplicant_process_proxy.cc
  504. supplicant_process_proxy.h
  505. supplicant_process_proxy_interface.h
  506. technology.cc
  507. technology.h
  508. technology_unittest.cc
  509. TESTING
  510. testrunner.cc
  511. user_bound_nlmessage.cc
  512. user_bound_nlmessage.h
  513. virtio_ethernet.cc
  514. virtio_ethernet.h
  515. vpn.cc
  516. vpn.h
  517. vpn_driver.cc
  518. vpn_driver.h
  519. vpn_driver_unittest.cc
  520. vpn_provider.cc
  521. vpn_provider.h
  522. vpn_provider_unittest.cc
  523. vpn_service.cc
  524. vpn_service.h
  525. vpn_service_unittest.cc
  526. vpn_unittest.cc
  527. wifi.cc
  528. wifi.h
  529. wifi_endpoint.cc
  530. wifi_endpoint.h
  531. wifi_endpoint_unittest.cc
  532. wifi_service.cc
  533. wifi_service.h
  534. wifi_service_unittest.cc
  535. wifi_unittest.cc
  536. wimax.cc
  537. wimax.h
  538. wimax_device_proxy.cc
  539. wimax_device_proxy.h
  540. wimax_device_proxy_interface.h
  541. wimax_manager_proxy.cc
  542. wimax_manager_proxy.h
  543. wimax_manager_proxy_interface.h
  544. wimax_network_proxy.cc
  545. wimax_network_proxy.h
  546. wimax_network_proxy_interface.h
  547. wimax_provider.cc
  548. wimax_provider.h
  549. wimax_provider_unittest.cc
  550. wimax_service.cc
  551. wimax_service.h
  552. wimax_service_unittest.cc
  553. wimax_unittest.cc
  554. wpa_supplicant.cc
  555. wpa_supplicant.h