commit 06175d70a09135fa0bac045807bca87c3c142289
author mukesh agrawal <quiche@chromium.org> Mon Apr 23 16:46:01 2012 -0700
committer Gerrit <chrome-bot@google.com> Fri Apr 27 16:25:53 2012 -0700
tree 1503deee5735ab728d24d1ed1dd6c64440cbc144
parent 4357f4ea204e5d3e7632d67f26531e106dd211e2

shill: improve logging

- add logging of D-Bus interactions
- convert some error->Populate calls to Error::PopulateAndLog
- slipped in: some whitespace and spelling fixes

BUG=chromium-os:29882
TEST=unit tests

Change-Id: I29cd455cb74cbf467e978a6dc7db3cadac248e43
Reviewed-on: https://gerrit.chromium.org/gerrit/21383
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>

modem_simple_proxy.cc

diff --git a/modem_simple_proxy.cc b/modem_simple_proxy.cc
index 3470e29..d51860f 100644
--- a/modem_simple_proxy.cc
+++ b/modem_simple_proxy.cc
@@ -8,6 +8,7 @@
 
 #include "shill/cellular_error.h"
 #include "shill/error.h"
+#include "shill/scope_logger.h"
 
 using base::Bind;
 using base::Callback;
@@ -30,6 +31,7 @@
                                       int timeout) {
   scoped_ptr<DBusPropertyMapCallback> cb(new DBusPropertyMapCallback(callback));
   try {
+    SLOG(DBus, 2) << __func__;
     proxy_.GetStatus(cb.get(), timeout);
     cb.release();
   } catch (DBus::Error e) {
@@ -44,6 +46,7 @@
                                int timeout) {
   scoped_ptr<ResultCallback> cb(new ResultCallback(callback));
   try {
+    SLOG(DBus, 2) << __func__;
     proxy_.Connect(properties, cb.get(), timeout);
     cb.release();
   } catch (DBus::Error e) {
@@ -62,6 +65,7 @@
 void ModemSimpleProxy::Proxy::GetStatusCallback(const DBusPropertiesMap &props,
                                                 const DBus::Error &dberror,
                                                 void *data) {
+  SLOG(DBus, 2) << __func__;
   scoped_ptr<DBusPropertyMapCallback> callback(
       reinterpret_cast<DBusPropertyMapCallback *>(data));
   Error error;
@@ -71,6 +75,7 @@
 
 void ModemSimpleProxy::Proxy::ConnectCallback(const DBus::Error &dberror,
                                               void *data) {
+  SLOG(DBus, 2) << __func__;
   scoped_ptr<ResultCallback> callback(reinterpret_cast<ResultCallback *>(data));
   Error error;
   CellularError::FromDBusError(dberror, &error);