| commit | 084facaf2ca23f176d080b2f70847edbb1d59aae | [log] [tgz] |
|---|---|---|
| author | Ben Chan <benchan@chromium.org> | Tue Jul 02 14:25:12 2013 -0700 |
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Thu Jan 09 05:30:33 2014 +0000 |
| tree | b586b7ad6f2446bf1561fbc24d83ef6f3151656d | |
| parent | 3f71326c17aa63e13343d06cbdc8ee0a2cbac3d7 [diff] |
shill: Allow DBus name watchers to be deleted. This CL refactors the code for watching DBus names as follows: 1. Adds a new DBusNameWatcher class. 2. Replaces DBusManager::WatchName() with DBusManager::CreateNameWatcher() returning a DBusNameWatcher, which can be deleted by the caller to unwatch the DBus name. 3. Removes MockDBusManager and changes unit tests to use DBusManager with a MockDBusServiceProxy. 4. Make related log messages more readable and consistent in format. BUG=chromium:214476 TEST=Tested the following: 1. Build and run unit tests with USE=wimax. 2. Manually verify, via /var/log/net.log, that shill can observe and handle the following scenarios when WPA supplicant and WiMAX manager appear on and vanish from DBus: - shill starts before WPA supplicant and WiMAX manager - shill starts after WPA supplicant and WiMAX manager Change-Id: I719806220c39de1296b62eb457c4610506a5b815 Reviewed-on: https://chromium-review.googlesource.com/181890 Commit-Queue: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org>