shill: reduce some copy-paste in dbus proxies
When making asynchronous D-Bus calls, we have to take
care not to leak Callback objects. This code occurs
in many places, but differs only in types.
Factor this code out into a template, to remove code
duplication.
CQ-DEPEND=CL:195761
BUG=chromium:365390
TEST=unit tests
Change-Id: Ica63045a00b9bbd70b3e12cb0939f0d7f1af0e1d
Reviewed-on: https://chromium-review.googlesource.com/195762
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>
diff --git a/modem_simple_proxy.cc b/modem_simple_proxy.cc
index 30b4bbd..57a3aa5 100644
--- a/modem_simple_proxy.cc
+++ b/modem_simple_proxy.cc
@@ -7,6 +7,7 @@
#include <base/bind.h>
#include "shill/cellular_error.h"
+#include "shill/dbus_async_call_helper.h"
#include "shill/error.h"
#include "shill/logging.h"
@@ -29,30 +30,17 @@
void ModemSimpleProxy::GetModemStatus(Error *error,
const DBusPropertyMapCallback &callback,
int timeout) {
- scoped_ptr<DBusPropertyMapCallback> cb(new DBusPropertyMapCallback(callback));
- try {
- SLOG(DBus, 2) << __func__;
- proxy_.GetStatus(cb.get(), timeout);
- cb.release();
- } catch (const DBus::Error &e) {
- if (error)
- CellularError::FromDBusError(e, error);
- }
+ BeginAsyncDBusCall(__func__, proxy_, &Proxy::GetStatusAsync, callback,
+ error, &CellularError::FromDBusError, timeout);
}
void ModemSimpleProxy::Connect(const DBusPropertiesMap &properties,
Error *error,
const ResultCallback &callback,
int timeout) {
- scoped_ptr<ResultCallback> cb(new ResultCallback(callback));
- try {
- SLOG(DBus, 2) << __func__;
- proxy_.Connect(properties, cb.get(), timeout);
- cb.release();
- } catch (const DBus::Error &e) {
- if (error)
- CellularError::FromDBusError(e, error);
- }
+ BeginAsyncDBusCall(__func__, proxy_, &Proxy::ConnectAsync, callback,
+ error, &CellularError::FromDBusError, timeout,
+ properties);
}
ModemSimpleProxy::Proxy::Proxy(DBus::Connection *connection,