commit | 75a68b9f230c7715cc24feee8a713e75e6e7f231 | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Thu Oct 24 10:50:27 2013 -0700 |
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | Fri Oct 25 03:09:58 2013 +0000 |
tree | ffb1a6f8892af5ca0280bc86c942825c9b8a2af1 | |
parent | 4ada1c74832bbb1c706d588e35257226760a17b0 [diff] |
shill: DHCPConfig: Optionally use minimal config Add another argument to the DHCPConfig constructor to specify whether a cut-down minimal set of options should be requested from the DHCP server. This adds a command line argument to the startup of the DHCP client. Propagate this upwards to the Device, and add a placeholder Device::ShouldUseMinimalConfig() method which will decide whether to enable this feature in the DHCPConfig in a later CL. A few ancillary changes went into this CL: - The DHCPProvider needed another argument to CreateConfig since it constructs DHCPConfig objects. - Added a unit test for the Device::ShouldUseArpGateway() superclass function next to Device::ShouldUseMinimalConfig() test. - Fixed the DHCPConfigTest::Start* tests to use the IsDHCPCDArgs matcher. For some reason that matcher sat unused and atrophied. Added a new test that exercises the minimal config flag. BUG=chromium:297607 TEST=Unit tests. Run network_DhcpNegotiationSuccess autotest. Change-Id: If0dcaf328ca6dfac7127a6badd409a4138c95760 Reviewed-on: https://chromium-review.googlesource.com/174531 Reviewed-by: Paul Stewart <pstew@chromium.org> Commit-Queue: Paul Stewart <pstew@chromium.org> Tested-by: Paul Stewart <pstew@chromium.org>