commit 15786033dc85e3dd7fea18ba936957b8b2c34e29
author Ben Chan <benchan@chromium.org> Sun Nov 04 21:28:02 2012 -0800
committer Gerrit <chrome-bot@google.com> Tue Nov 06 05:03:13 2012 -0800
tree 641700432908320fee59840a5fd030e2a152950e
parent 9332c1fcafedb798ae6ad2c7a87287432c3c6f22

shill: cellular: Determine if service activation is required.

BUG=chrome-os-partner:10631
TEST=Build and run unit tests.

Change-Id: I2d23994b07aca2fc685318273f6dcc8a76a344f9
Reviewed-on: https://gerrit.chromium.org/gerrit/37358
Commit-Ready: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>

cellular_capability_universal_unittest.cc

diff --git a/cellular_capability_universal_unittest.cc b/cellular_capability_universal_unittest.cc
index cf0b0c3..3bcdd0c 100644
--- a/cellular_capability_universal_unittest.cc
+++ b/cellular_capability_universal_unittest.cc
@@ -20,6 +20,7 @@
 #include "shill/error.h"
 #include "shill/event_dispatcher.h"
 #include "shill/mock_adaptors.h"
+#include "shill/mock_cellular_operator_info.h"
 #include "shill/mock_cellular_service.h"
 #include "shill/mock_dbus_properties_proxy.h"
 #include "shill/mock_glib.h"
@@ -231,6 +232,7 @@
   TestProxyFactory proxy_factory_;
   CellularCapabilityUniversal *capability_;  // Owned by |cellular_|.
   NiceMock<DeviceMockAdaptor> *device_adaptor_;  // Owned by |cellular_|.
+  MockCellularOperatorInfo cellular_operator_info_;
   mobile_provider_db *provider_db_;
   CellularRefPtr cellular_;
   MockCellularService *service_;  // owned by cellular_
@@ -934,4 +936,29 @@
             capability_->CreateFriendlyServiceName());
 }
 
+TEST_F(CellularCapabilityUniversalTest, IsServiceActivationRequired) {
+  capability_->mdn_ = "0000000000";
+  cellular_->cellular_operator_info_ = NULL;
+  EXPECT_FALSE(capability_->IsServiceActivationRequired());
+
+  cellular_->cellular_operator_info_ = &cellular_operator_info_;
+  EXPECT_CALL(cellular_operator_info_, GetOLP(_, _))
+      .WillOnce(Return(false))
+      .WillRepeatedly(Return(true));
+  EXPECT_FALSE(capability_->IsServiceActivationRequired());
+
+  capability_->mdn_ = "";
+  EXPECT_FALSE(capability_->IsServiceActivationRequired());
+  capability_->mdn_ = "1234567890";
+  EXPECT_FALSE(capability_->IsServiceActivationRequired());
+  capability_->mdn_ = "+1-234-567-890";
+  EXPECT_FALSE(capability_->IsServiceActivationRequired());
+  capability_->mdn_ = "0000000000";
+  EXPECT_TRUE(capability_->IsServiceActivationRequired());
+  capability_->mdn_ = "0-000-000-000";
+  EXPECT_TRUE(capability_->IsServiceActivationRequired());
+  capability_->mdn_ = "+0-000-000-000";
+  EXPECT_TRUE(capability_->IsServiceActivationRequired());
+}
+
 }  // namespace shill