shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
diff --git a/device_dbus_adaptor.cc b/device_dbus_adaptor.cc
index 521ef9f..564b811 100644
--- a/device_dbus_adaptor.cc
+++ b/device_dbus_adaptor.cc
@@ -71,7 +71,7 @@
}
void DeviceDBusAdaptor::ClearProperty(const std::string& ,
- ::DBus::Error &error) {
+ ::DBus::Error &/*error*/) {
}
void DeviceDBusAdaptor::ProposeScan(::DBus::Error &error) {
@@ -81,7 +81,7 @@
}
::DBus::Path DeviceDBusAdaptor::AddIPConfig(const string& ,
- ::DBus::Error &error) {
+ ::DBus::Error &/*error*/) {
return ::DBus::Path();
}