shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
diff --git a/ipconfig_dbus_adaptor.cc b/ipconfig_dbus_adaptor.cc
index 226adec..e409684 100644
--- a/ipconfig_dbus_adaptor.cc
+++ b/ipconfig_dbus_adaptor.cc
@@ -77,19 +77,19 @@
}
}
-void IPConfigDBusAdaptor::ClearProperty(const std::string& name,
- ::DBus::Error &error) {
+void IPConfigDBusAdaptor::ClearProperty(const std::string& /*name*/,
+ ::DBus::Error &/*error*/) {
}
-void IPConfigDBusAdaptor::Remove(::DBus::Error &error) {
+void IPConfigDBusAdaptor::Remove(::DBus::Error &/*error*/) {
}
-void IPConfigDBusAdaptor::MoveBefore(const ::DBus::Path& path,
- ::DBus::Error &error) {
+void IPConfigDBusAdaptor::MoveBefore(const ::DBus::Path& /*path*/,
+ ::DBus::Error &/*error*/) {
}
-void IPConfigDBusAdaptor::MoveAfter(const ::DBus::Path& path,
- ::DBus::Error &error) {
+void IPConfigDBusAdaptor::MoveAfter(const ::DBus::Path& /*path*/,
+ ::DBus::Error &/*error*/) {
}
} // namespace shill