commit 1830fa1f2e8691073f4d07b0883f059a290a9cc2
author mukesh agrawal <quiche@chromium.org> Mon Sep 26 14:31:40 2011 -0700
committer mukesh agrawal <quiche@chromium.org> Tue Sep 27 13:39:00 2011 -0700
tree 887fc31d1f44b5f630f23e47d073d154109bfe54
parent 71bfc8fb15c4ddbeee8a5477c8ad4aa46541e377

shill: enable (don't disable) -Wunused

having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)

BUG=chromium-os:20779
TEST=unittests

- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast

Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>

manager_dbus_adaptor.cc

diff --git a/manager_dbus_adaptor.cc b/manager_dbus_adaptor.cc
index 7c071cf..27bba64 100644
--- a/manager_dbus_adaptor.cc
+++ b/manager_dbus_adaptor.cc
@@ -91,32 +91,33 @@
   }
 }
 
-string ManagerDBusAdaptor::GetState(::DBus::Error &error) {
+string ManagerDBusAdaptor::GetState(::DBus::Error &/*error*/) {
   return string();
 }
 
 ::DBus::Path ManagerDBusAdaptor::CreateProfile(const string &name,
-                                               ::DBus::Error &error) {
+                                               ::DBus::Error &/*error*/) {
   NOTIMPLEMENTED();
   // TODO(quiche): implement this
   return ::DBus::Path("/" + name);
 }
 
-void ManagerDBusAdaptor::RemoveProfile(const string &name,
-                                       ::DBus::Error &error) {
+void ManagerDBusAdaptor::RemoveProfile(const string &/*name*/,
+                                       ::DBus::Error &/*error*/) {
 }
 
 ::DBus::Path ManagerDBusAdaptor::PushProfile(const std::string &name,
-                                             ::DBus::Error &error) {
+                                             ::DBus::Error &/*error*/) {
   NOTIMPLEMENTED();
   // TODO(quiche): implement this
   return ::DBus::Path("/" + name);
 }
 
-void ManagerDBusAdaptor::PopProfile(const std::string &, ::DBus::Error &error) {
+void ManagerDBusAdaptor::PopProfile(const std::string &,
+                                    ::DBus::Error &/*error*/) {
 }
 
-void ManagerDBusAdaptor::PopAnyProfile(::DBus::Error &error) {
+void ManagerDBusAdaptor::PopAnyProfile(::DBus::Error &/*error*/) {
 }
 
 void ManagerDBusAdaptor::RequestScan(const string &technology,
@@ -127,11 +128,11 @@
 }
 
 void ManagerDBusAdaptor::EnableTechnology(const string &,
-                                          ::DBus::Error &error) {
+                                          ::DBus::Error &/*error*/) {
 }
 
 void ManagerDBusAdaptor::DisableTechnology(const string &,
-                                           ::DBus::Error &error) {
+                                           ::DBus::Error &/*error*/) {
 }
 
 // deprecated synonym for GetWifiService
@@ -164,36 +165,36 @@
 
 void ManagerDBusAdaptor::ConfigureWifiService(
     const map<string, ::DBus::Variant> &,
-    ::DBus::Error &error) {
+    ::DBus::Error &/*error*/) {
 }
 
 ::DBus::Path ManagerDBusAdaptor::GetVPNService(
     const map<string, ::DBus::Variant> &,
-    ::DBus::Error &error) {
+    ::DBus::Error &/*error*/) {
   return ::DBus::Path();
 }
 
 void ManagerDBusAdaptor::RegisterAgent(const ::DBus::Path &,
-                                       ::DBus::Error &error) {
+                                       ::DBus::Error &/*error*/) {
 }
 
 void ManagerDBusAdaptor::UnregisterAgent(const ::DBus::Path &,
-                                         ::DBus::Error &error) {
+                                         ::DBus::Error &/*error*/) {
 }
 
-int32_t ManagerDBusAdaptor::GetDebugLevel(::DBus::Error &error) {
+int32_t ManagerDBusAdaptor::GetDebugLevel(::DBus::Error &/*error*/) {
   return logging::GetMinLogLevel();
 }
 
 void ManagerDBusAdaptor::SetDebugLevel(const int32_t &level,
-                                      ::DBus::Error &error) {
+                                       ::DBus::Error &/*error*/) {
   if (level < logging::LOG_NUM_SEVERITIES)
     logging::SetMinLogLevel(level);
   else
     LOG(WARNING) << "Ignoring attempt to set log level to " << level;
 }
 
-string ManagerDBusAdaptor::GetServiceOrder(::DBus::Error &error) {
+string ManagerDBusAdaptor::GetServiceOrder(::DBus::Error &/*error*/) {
   return manager_->GetTechnologyOrder();
 }