shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
diff --git a/modem_manager.cc b/modem_manager.cc
index b1c60a4..090a5b1 100644
--- a/modem_manager.cc
+++ b/modem_manager.cc
@@ -76,7 +76,7 @@
proxy_.reset();
}
-void ModemManager::OnAppear(GDBusConnection *connection,
+void ModemManager::OnAppear(GDBusConnection */*connection*/,
const gchar *name,
const gchar *name_owner,
gpointer user_data) {
@@ -85,7 +85,7 @@
manager->Connect(name_owner);
}
-void ModemManager::OnVanish(GDBusConnection *connection,
+void ModemManager::OnVanish(GDBusConnection */*connection*/,
const gchar *name,
gpointer user_data) {
LOG(INFO) << "Modem manager " << name << " vanished.";