shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
diff --git a/nice_mock_control.cc b/nice_mock_control.cc
index 09e1917..26d0af4 100644
--- a/nice_mock_control.cc
+++ b/nice_mock_control.cc
@@ -16,27 +16,28 @@
NiceMockControl::~NiceMockControl() {}
-DeviceAdaptorInterface *NiceMockControl::CreateDeviceAdaptor(Device *device) {
+DeviceAdaptorInterface *NiceMockControl::CreateDeviceAdaptor(
+ Device */*device*/) {
return new NiceMock<DeviceMockAdaptor>();
}
IPConfigAdaptorInterface *NiceMockControl::CreateIPConfigAdaptor(
- IPConfig *config) {
+ IPConfig */*config*/) {
return new NiceMock<IPConfigMockAdaptor>();
}
ManagerAdaptorInterface *NiceMockControl::CreateManagerAdaptor(
- Manager *manager) {
+ Manager */*manager*/) {
return new NiceMock<ManagerMockAdaptor>();
}
ProfileAdaptorInterface *NiceMockControl::CreateProfileAdaptor(
- Profile *profile) {
+ Profile */*profile*/) {
return new NiceMock<ProfileMockAdaptor>();
}
ServiceAdaptorInterface *NiceMockControl::CreateServiceAdaptor(
- Service *service) {
+ Service */*service*/) {
return new NiceMock<ServiceMockAdaptor>();
}