shill: enable (don't disable) -Wunused
having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)
BUG=chromium-os:20779
TEST=unittests
- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast
Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
diff --git a/service_unittest.cc b/service_unittest.cc
index efbd149..860c13c 100644
--- a/service_unittest.cc
+++ b/service_unittest.cc
@@ -8,8 +8,8 @@
#include <string>
#include <vector>
-#include <dbus-c++/dbus.h>
#include <chromeos/dbus/service_constants.h>
+#include <dbus-c++/dbus.h>
#include <gtest/gtest.h>
#include <gmock/gmock.h>
@@ -48,7 +48,7 @@
: Service(control_interface, dispatcher, manager, "stub") {}
virtual ~ServiceUnderTest() {}
- virtual void Connect(Error *error) {}
+ virtual void Connect(Error */*error*/) {}
virtual void Disconnect() {}
virtual string CalculateState() { return ""; }
virtual string GetRpcIdentifier() const { return ServiceMockAdaptor::kRpcId; }