commit 1830fa1f2e8691073f4d07b0883f059a290a9cc2
author mukesh agrawal <quiche@chromium.org> Mon Sep 26 14:31:40 2011 -0700
committer mukesh agrawal <quiche@chromium.org> Tue Sep 27 13:39:00 2011 -0700
tree 887fc31d1f44b5f630f23e47d073d154109bfe54
parent 71bfc8fb15c4ddbeee8a5477c8ad4aa46541e377

shill: enable (don't disable) -Wunused

having fixed an unused parameter in the dbus-c++ headers, those
headers no longer have unused parameters. so, if we fix up unused
parameters in shill code, we can compile with -Wunused. (this is
implied by -Wall, as long as we don't override with -Wno-unused.)

BUG=chromium-os:20779
TEST=unittests

- comment out unused parameters in function definitions
- remove some unused local variables
- also: fix an old-style cast

Change-Id: Ie654a7b34d622cecb0f26bd47c17813fe8423001
Reviewed-on: http://gerrit.chromium.org/gerrit/8365
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>

supplicant_interface_proxy.cc

diff --git a/supplicant_interface_proxy.cc b/supplicant_interface_proxy.cc
index 64dbc1c..ebc5db0 100644
--- a/supplicant_interface_proxy.cc
+++ b/supplicant_interface_proxy.cc
@@ -58,12 +58,12 @@
 
 SupplicantInterfaceProxy::Proxy::~Proxy() {}
 
-void SupplicantInterfaceProxy::Proxy::BlobAdded(const string &blobname) {
+void SupplicantInterfaceProxy::Proxy::BlobAdded(const string &/*blobname*/) {
   LOG(INFO) << __func__;
   // XXX
 }
 
-void SupplicantInterfaceProxy::Proxy::BlobRemoved(const string &blobname) {
+void SupplicantInterfaceProxy::Proxy::BlobRemoved(const string &/*blobname*/) {
   LOG(INFO) << __func__;
   // XXX
 }
@@ -75,32 +75,32 @@
   wifi_->BSSAdded(BSS, properties);
 }
 
-void SupplicantInterfaceProxy::Proxy::BSSRemoved(const ::DBus::Path &BSS) {
+void SupplicantInterfaceProxy::Proxy::BSSRemoved(const ::DBus::Path &/*BSS*/) {
   LOG(INFO) << __func__;
   // XXX
 }
 
 void SupplicantInterfaceProxy::Proxy::NetworkAdded(
-    const ::DBus::Path &network,
-    const std::map<string, ::DBus::Variant> &properties) {
+    const ::DBus::Path &/*network*/,
+    const std::map<string, ::DBus::Variant> &/*properties*/) {
   LOG(INFO) << __func__;
   // XXX
 }
 
 void SupplicantInterfaceProxy::Proxy::NetworkRemoved(
-    const ::DBus::Path &network) {
+    const ::DBus::Path &/*network*/) {
   LOG(INFO) << __func__;
   // XXX
 }
 
 void SupplicantInterfaceProxy::Proxy::NetworkSelected(
-    const ::DBus::Path &network) {
+    const ::DBus::Path &/*network*/) {
   LOG(INFO) << __func__;
   // XXX
 }
 
 void SupplicantInterfaceProxy::Proxy::PropertiesChanged(
-    const std::map<string, ::DBus::Variant> &properties) {
+    const std::map<string, ::DBus::Variant> &/*properties*/) {
   LOG(INFO) << __func__;
   // XXX
 }