commit | 27526f1dad75e135f437e023cb34b0919d9a981f | [log] [tgz] |
---|---|---|
author | Prathmesh Prabhu <pprabhu@chromium.org> | Mon Mar 25 19:42:18 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Fri Mar 29 12:45:05 2013 -0700 |
tree | 99c01339059ada0285504f80d1bc9ab62ce4c960 | |
parent | c4c9d7c48886fbd34b507d44f12c3722864f57e9 [diff] |
shill: cellular: Consolidate singletons passed through constructors The following are singletons that were stored individually by many classes, passed down constructors as the objects were created. Move singletons to ModemInfo, and pass only a ModemInfo object down. Singletons: ControlInterface, EventDispatcher, Metrics, Manager, GLib, ActivatingIccidStore, CellularOperatorInfo, and mobile_provider_db. Classes who stored all these singletons: ModemInfo, Cellular, ModemManager (and flavours), Modem (and flavours), CellularCpability (and flavours). BUG=chromium:222543 TEST=(1) Build and run unit tests. (2) Test on device that LTE activation and cellular functionality related to refactored singletons still works. (3) Run autotest: network_3GSmokeTest. Change-Id: I0c2866e0cd0bab63e3c3078ff73361322a8f509b Reviewed-on: https://gerrit.chromium.org/gerrit/46485 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>