commit | 1c01befda41e1dfe1828f898384b6aff035aba92 | [log] [tgz] |
---|---|---|
author | Darin Petkov <petkov@chromium.org> | Thu Sep 13 15:27:17 2012 +0200 |
committer | Gerrit <chrome-bot@google.com> | Thu Sep 13 10:48:30 2012 -0700 |
tree | 407eef877c2b47b026a76dbfe9859e60f07c9ccc | |
parent | 1abca3e66f091c0afb74f3ba9e1f95e9a4a153c0 [diff] |
shill: cellular: Don't hang on to the Device instance just for termination. The Cellular device used to register a termination hook using a reference counted pointer to its instance. This prevented shill from destructing the Cellular device instance when all other references were eliminated (e.g., when a Modem RPC instance disappeared) which caused a shill crash on Modem RPC reappearance. This patch switches the termination hook to a weak pointer which allows Cellular device destruction. BUG=chromium-os:34398 TEST=see bug report Change-Id: I0bb7622e54e67000d4fa7c98ed11d9657ade2d8d Reviewed-on: https://gerrit.chromium.org/gerrit/33196 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Reviewed-by: Gary Morain <gmorain@chromium.org> Commit-Ready: Darin Petkov <petkov@chromium.org>