commit 2697aa9f22fec28f14a954e11368bd7d16073ffb
author Ben Chan <benchan@chromium.org> Mon Oct 22 22:25:10 2012 -0700
committer Gerrit <chrome-bot@google.com> Tue Oct 23 01:08:28 2012 -0700
tree 0f7b17c0c38759dd1aa0172d2e22370b7a292fb4
parent e6ca32073238c7880a65559746c47f1adaf32061

shill: Fix assertion in HTTPRequest::WriteToServer.

BUG=chromium-os:35614
TEST=Build and run unit tests.

Change-Id: I38f8384e779f2ef50c8e54a07ba3441766c6e9c7
Reviewed-on: https://gerrit.chromium.org/gerrit/36321
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>

http_request.cc

diff --git a/http_request.cc b/http_request.cc
index 98d9020..d924ccd 100644
--- a/http_request.cc
+++ b/http_request.cc
@@ -249,7 +249,7 @@
   CHECK_EQ(server_socket_, fd);
   int ret = sockets_->Send(fd, request_data_.GetConstData(),
                            request_data_.GetLength(), 0);
-  CHECK(static_cast<size_t>(ret) <= request_data_.GetLength());
+  CHECK(ret < 0 || static_cast<size_t>(ret) <= request_data_.GetLength());
 
   SLOG(HTTP, 3) << "In " << __func__ << " wrote " << ret << " of "
                 << request_data_.GetLength();