commit 284fe797377b574717e6f61196219fece1cbe85b
author Thieu Le <thieule@chromium.org> Tue Jan 31 17:53:19 2012 -0800
committer Gerrit <chrome-bot@google.com> Wed Feb 01 14:42:38 2012 -0800
tree 3e246a86088b0ab11879257eadcc1fadb041fc6a
parent 313324136473f9120b1e485a408f51ae938dcb64

shill: make access to Service.AutoConnect consistent with flimflam

Service.AutoConnect is writable only if the Favorite property is true.

BUG=chromium-os:23342
TEST=Unit tests, network_WiFiManager (7/9)

Change-Id: Ia76e1bfb39e51b62352b97131d14a672fdc45f6d
Reviewed-on: https://gerrit.chromium.org/gerrit/15156
Commit-Ready: Thieu Le <thieule@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>

service_unittest.cc

diff --git a/service_unittest.cc b/service_unittest.cc
index be325c4..8f2daab 100644
--- a/service_unittest.cc
+++ b/service_unittest.cc
@@ -79,6 +79,7 @@
   {
     ::DBus::Error dbus_error;
     bool expected = true;
+    service_->set_favorite(true);
     service_->mutable_store()->SetBoolProperty(flimflam::kAutoConnectProperty,
                                                expected,
                                                &error);
@@ -144,6 +145,23 @@
                                              &error));
     EXPECT_EQ(invalid_args(), error.name());
   }
+  {
+    ::DBus::Error error;
+    service_->set_favorite(true);
+    EXPECT_TRUE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
+                                            flimflam::kAutoConnectProperty,
+                                            PropertyStoreTest::kBoolV,
+                                            &error));
+  }
+  {
+    ::DBus::Error error;
+    service_->set_favorite(false);
+    EXPECT_FALSE(DBusAdaptor::DispatchOnType(service_->mutable_store(),
+                                             flimflam::kAutoConnectProperty,
+                                             PropertyStoreTest::kBoolV,
+                                             &error));
+    EXPECT_EQ(invalid_args(), error.name());
+  }
 }
 
 TEST_F(ServiceTest, Load) {