| commit | 4afba20439a10cd7e30831ac8ba664ca468a0bd6 | [log] [tgz] |
|---|---|---|
| author | Han Shen <shenhan@google.com> | Mon Dec 17 08:48:35 2012 -0800 |
| committer | Gerrit <chrome-bot@google.com> | Mon Dec 17 15:18:40 2012 -0800 |
| tree | 3b14e3127d83d63fcef1e7f14c19c03b92f17bea | |
| parent | 618af2b8d701e1033c178857012de58f23aaa252 [diff] |
Fix shill unittest bugs - singleton instances must be handled properly across different unittests. Unittests for shill is a single executable, which run each unittest one by one, so for each singleton, we must setup up and clear properly, we must not make any assumption that this singleton is used only for a particular test. For instance in config80211_unittest.cc, singleton member 'Config80211::sock_' is assigned a value which invalidates right after Config80211Test finishes, when later ShillDaemonTest::Start comes to this non-NULL value, thinking that this is properly initialized and makes a call on it, the program crashes. TEST=all shill tests passed after fixing (was crashing) BUG=None Change-Id: Ifd17bfca319e4f5d93cb82bdde010d9a5db36dcd Reviewed-on: https://gerrit.chromium.org/gerrit/39771 Reviewed-by: Wade Guthrie <wdg@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Commit-Ready: Han Shen <shenhan@chromium.org> Tested-by: Han Shen <shenhan@chromium.org>