| commit | 2f1bbf02bf310aee36ee29d716a73bf544dcee82 | [log] [tgz] |
|---|---|---|
| author | Christopher Wiley <wiley@chromium.org> | Thu Oct 25 15:31:13 2012 -0700 |
| committer | Gerrit <chrome-bot@google.com> | Wed Oct 31 16:37:49 2012 -0700 |
| tree | 66e74f1958deee7db8e2ffb38b9ce294f3fc3202 | |
| parent | a5b4a4d62198794cd4885c845e48f30ead0bc520 [diff] |
shill: Make EthernetService behave more like a Service Add Connect() and Disconnect() calls to EthernetService so that they behave more like a Service and less like strange extensions of the Ethernet object. This has the nice side effect that the Manager can autoconnect them, which adds a certain amount of fault tolerance to the L3 configuration. This in turn fixes a bug where DHCP negotiation timing out over ethernet is incorrectly reported in shill. BUG=chromium-os:35603 TEST=Unit tests pass, I can hand connect/disconnect to ethernet, DHCP autotests for basic negotiation success and renewal timeouts pass. Added another simple unit test. Change-Id: I35aa2f5d2d8155bf0d24a80c7da9ddf41348ab03 Reviewed-on: https://gerrit.chromium.org/gerrit/36625 Tested-by: Christopher Wiley <wiley@chromium.org> Commit-Ready: Christopher Wiley <wiley@chromium.org> Reviewed-by: Christopher Wiley <wiley@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org>