commit 34af218abe6a99144ffe01332ce36fbad94f2628
author Chris Masone <cmasone@chromium.org> Mon Aug 22 11:59:36 2011 -0700
committer Chris Masone <cmasone@chromium.org> Mon Aug 22 15:06:46 2011 -0700
tree 945f160f913a90aa85501df623d5b95e62d5126b
parent 3335b3773067671301a8a02a1f9eefd17a3ce607

[shill] Use flimflam-esque storage ids

Devices:
  device_<MAC>

IPConfig:
  ipconfig_<MAC of associated device>_0

Services:
  ethernet_<MAC of associated device>
  wifi_<MAC of associated device>_<SSID>_<mode>_<security>
  cellular_<MAC of associated device>_<Network_name>

BUG=chromium-os:17744
TEST=unit

Change-Id: Ibf061f9c184e7c86f5afcf97d48e321fc74bde1c
Reviewed-on: http://gerrit.chromium.org/gerrit/6412
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

service_unittest.cc

diff --git a/service_unittest.cc b/service_unittest.cc
index 9db2d9e..269379f 100644
--- a/service_unittest.cc
+++ b/service_unittest.cc
@@ -44,14 +44,18 @@
       : service_(new MockService(&control_interface_,
                                  &dispatcher_,
                                  &manager_)),
-        service_name_(service_->UniqueName()) {
+        storage_id_("service") {
+    EXPECT_CALL(*service_.get(), GetStorageIdentifier(_))
+        .WillRepeatedly(Return(storage_id_));
+    EXPECT_CALL(*service_.get(), GetRpcIdentifier())
+        .WillRepeatedly(Return(ServiceMockAdaptor::kRpcId));
   }
 
   virtual ~ServiceTest() {}
 
  protected:
   scoped_refptr<MockService> service_;
-  string service_name_;
+  string storage_id_;
 };
 
 const char ServiceTest::kMockDeviceRpcId[] = "mock-device-rpc";
@@ -150,70 +154,64 @@
   }
 }
 
-TEST_F(ServiceTest, GetStorageIdentifier) {
-  EXPECT_EQ(service_name_, service_->GetStorageIdentifier());
-}
-
 TEST_F(ServiceTest, Load) {
   NiceMock<MockStore> storage;
-  const string id = service_name_;
-  EXPECT_CALL(storage, ContainsGroup(id)).WillOnce(Return(true));
-  EXPECT_CALL(storage, GetString(id, _, _))
+  EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(true));
+  EXPECT_CALL(storage, GetString(storage_id_, _, _))
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
-  EXPECT_TRUE(service_->Load(&storage));
+  EXPECT_TRUE(service_->Load(&storage, ""));
 }
 
 TEST_F(ServiceTest, LoadFail) {
   StrictMock<MockStore> storage;
-  EXPECT_CALL(storage, ContainsGroup(service_name_)).WillOnce(Return(false));
-  EXPECT_FALSE(service_->Load(&storage));
+  EXPECT_CALL(storage, ContainsGroup(storage_id_)).WillOnce(Return(false));
+  EXPECT_FALSE(service_->Load(&storage, ""));
 }
 
 TEST_F(ServiceTest, SaveString) {
   MockStore storage;
   static const char kKey[] = "test-key";
   static const char kData[] = "test-data";
-  EXPECT_CALL(storage, SetString(service_name_, kKey, kData))
+  EXPECT_CALL(storage, SetString(storage_id_, kKey, kData))
       .WillOnce(Return(true));
-  service_->SaveString(&storage, kKey, kData, false, true);
+  service_->SaveString(&storage, storage_id_, kKey, kData, false, true);
 }
 
 TEST_F(ServiceTest, SaveStringCrypted) {
   MockStore storage;
   static const char kKey[] = "test-key";
   static const char kData[] = "test-data";
-  EXPECT_CALL(storage, SetCryptedString(service_name_, kKey, kData))
+  EXPECT_CALL(storage, SetCryptedString(storage_id_, kKey, kData))
       .WillOnce(Return(true));
-  service_->SaveString(&storage, kKey, kData, true, true);
+  service_->SaveString(&storage, storage_id_, kKey, kData, true, true);
 }
 
 TEST_F(ServiceTest, SaveStringDontSave) {
   MockStore storage;
   static const char kKey[] = "test-key";
-  EXPECT_CALL(storage, DeleteKey(service_name_, kKey))
+  EXPECT_CALL(storage, DeleteKey(storage_id_, kKey))
       .WillOnce(Return(true));
-  service_->SaveString(&storage, kKey, "data", false, false);
+  service_->SaveString(&storage, storage_id_, kKey, "data", false, false);
 }
 
 TEST_F(ServiceTest, SaveStringEmpty) {
   MockStore storage;
   static const char kKey[] = "test-key";
-  EXPECT_CALL(storage, DeleteKey(service_name_, kKey))
+  EXPECT_CALL(storage, DeleteKey(storage_id_, kKey))
       .WillOnce(Return(true));
-  service_->SaveString(&storage, kKey, "", true, true);
+  service_->SaveString(&storage, storage_id_, kKey, "", true, true);
 }
 
 TEST_F(ServiceTest, Save) {
   NiceMock<MockStore> storage;
-  const string id = service_name_;
-  EXPECT_CALL(storage, SetString(id, _, _))
+  EXPECT_CALL(storage, SetString(storage_id_, _, _))
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
-  EXPECT_CALL(storage, DeleteKey(id, _))
+  EXPECT_CALL(storage, DeleteKey(storage_id_, _))
       .Times(AtLeast(1))
       .WillRepeatedly(Return(true));
-  EXPECT_TRUE(service_->Save(&storage));
+  EXPECT_TRUE(service_->Save(&storage, ""));
 }
 
 }  // namespace shill