commit | 3ffe52c6eb79db079a8b5685d2c8bd96f6b49b79 | [log] [tgz] |
---|---|---|
author | mukesh agrawal <quiche@chromium.org> | Thu Jun 20 15:21:29 2013 -0700 |
committer | ChromeBot <chrome-bot@google.com> | Thu Jun 20 22:56:14 2013 -0700 |
tree | b596b100694ef519cd42d642c8b1437502769f38 | |
parent | 7b310a19a7f6321876c0838f435e156c1f8c0de2 [diff] |
shill: provide username/password support for PPP dongles Add PPP username and password properties to CellularService, and provide these values to pppd when queried via the GetLogin callback. Note that we're not really sure whether or not PPP username/password is used for network authentication, as the PPP endpoint may be on the dongle itself. Nonetheless, provide this functionality in case it proves to be necessary. While there: remove some storage constants from the public interface of Cellular. BUG=chromium:246443 TEST=unit tests, manual Manual test ----------- - restart shill SHILL_LOG_LEVEL=-5 SHILL_LOG_SCOPES=+cellular+service+ppp - plug in dongle - wait for cellular to connect - find cellular service in chrome://network (e.g. "/service/2") - dbus-send --system --print-reply --dest=org.chromium.flimflam \ <service> org.chromium.flimflam.Service.SetProperty \ string:Cellular.PPP.Username variant:string:fake-userid in this example, <service> would be /service/2 - grep "Cellular.PPP.Username=fake-userid" /var/run/shill/user_profiles/chronos/shill.profile (if not logged in to chromeos, use /var/cache/shill/default.profile instead) -> should match - remove dongle - insert dongle - wait for cellular to connect - egrep "fake-userid" /var/log/net.log -> should match. e.g. <timestamp> localhost pppd[<pid>]: sent [CHAP Response id=0x1 <random string>, name = "fake-userid"] Change-Id: I55954e76ab3ab3c911406bf76fbc879fa5e85849 Reviewed-on: https://gerrit.chromium.org/gerrit/59509 Commit-Queue: mukesh agrawal <quiche@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Tested-by: mukesh agrawal <quiche@chromium.org>