shill: Makes unknown nl80211 messages look like Nl80211Messages.
Before, when NetlinkMessage::CreateMessage was given an nl80211 message
that it didn't recognize, the code generated something that was a
sort-of hybrid between a vanilla NetlinkMessage and an Nl80211Message
(with disasterous results). This makes the unknown message look just
like an Nl80211Message.
The specific problem this addresses happened because a developer added a
new message type but hadn't, yet, added it to the factory. This generated
an UnknownMessage and passed it to the message handler.
BUG=None
TEST=unitest
Change-Id: I78bc0861725c660f794c9eec2b99d23dded7d7a2
Reviewed-on: https://gerrit.chromium.org/gerrit/50525
Commit-Queue: Wade Guthrie <wdg@chromium.org>
Reviewed-by: Wade Guthrie <wdg@chromium.org>
Tested-by: Wade Guthrie <wdg@chromium.org>
diff --git a/nl80211_message.cc b/nl80211_message.cc
index 738e0e4..5b142c3 100644
--- a/nl80211_message.cc
+++ b/nl80211_message.cc
@@ -723,7 +723,9 @@
case UnprotDisassociateMessage::kCommand:
return new UnprotDisassociateMessage();
default:
- LOG(WARNING) << "Unknown/unhandled netlink nl80211 message " << gnlh->cmd;
+ LOG(WARNING) << StringPrintf(
+ "Unknown/unhandled netlink nl80211 message 0x%02x", gnlh->cmd);
+ return new UnknownNl80211Message(gnlh->cmd);
break;
}
return NULL;