commit | 451aa7f3e44642da0598c526030b41c6963c55d3 | [log] [tgz] |
---|---|---|
author | Paul Stewart <pstew@chromium.org> | Wed Apr 11 19:07:58 2012 -0700 |
committer | Gerrit <chrome-bot@google.com> | Thu Apr 12 11:05:34 2012 -0700 |
tree | ed7e81e269cf082a01f01913e50dedc831da2eec | |
parent | 2bf424f60d2c55dbad2d5a9a3f63f4fa32b8864b [diff] |
shill: vpn: Properly export provider properties Provider properties should be exported as a "Provider" dict instead of at the same toplevel as the rest of the Service properties. This means that there is a difference between the way these properties are stored in the keystore and accesed over DBus for writing and how they are enumerated in "GetProperties". Also fix VPNProvider::GetService so that all properties are applied, even the ones that should modify Service level attributes, like GUID and UIData, by using Service::Configure instead of passing the KeyValueStore directly into the driver. BUG=chromium-os:29287 TEST=New unit tests + Manual: - Test that logging in to an ONC-enabled account creates the service automatically. Moreover, make sure that the profile data is written out and materially quite similar to flimflam's profile data. - Test that logging out and logging back in maintains that data. - Test that the VPN entry appears in the networks dropdown Change-Id: I60a807886d17074d3f88b1475dcf42e80c0cec54 Reviewed-on: https://gerrit.chromium.org/gerrit/20046 Commit-Ready: Darin Petkov <petkov@chromium.org> Reviewed-by: Darin Petkov <petkov@chromium.org> Tested-by: Darin Petkov <petkov@chromium.org>