commit | 4682aa877598abf04e7ae0f13aa4166cac90be9d | [log] [tgz] |
---|---|---|
author | Darin Petkov <petkov@chromium.org> | Thu May 31 16:24:11 2012 +0200 |
committer | Gerrit <chrome-bot@google.com> | Thu May 31 11:51:34 2012 -0700 |
tree | c43be1980f2c6166c49ddc9d556d8352c14ae0dc | |
parent | e636c6945299da860b360c4ed83c318e3ec41ede [diff] |
shill: Avoid double gets of property store values when iterating. Cleanup and simplify the property iterator classes by removing the unused PropertyConstIterator class and caching the property value. This way we avoid deriving property values twice when iterating through properties. Also, remove some incorrect and unused logic in the PropertyStoreInspector related to handling errors coming from the property store iterators. BUG=chromium-os:30373 TEST=unit tests Change-Id: Ie6ba2696f070e1ed43997f17273f48360f85055b Reviewed-on: https://gerrit.chromium.org/gerrit/24201 Tested-by: Darin Petkov <petkov@chromium.org> Reviewed-by: Paul Stewart <pstew@chromium.org> Reviewed-by: mukesh agrawal <quiche@chromium.org> Commit-Ready: Darin Petkov <petkov@chromium.org>