shill: perform connection diagnostics after portal detection failure

Perform connection diagnostics after portal detection fails
for a particular device. This will provide more information
in the logs about what connectivity issue shill is experiencing.

Also, have connection diagnostics log the likely connection issue
to LOG(INFO) (instead of WiFi logs level -4) when it is done.
This ensures that the results of the diagnostics appear in
feedback reports at the default logging level.

BUG=chromium:216691
TEST=Compile shill and run unit tests.

Change-Id: I4688a384e83fb8faefd6015413d4ca38444aa8a6
Reviewed-on: https://chromium-review.googlesource.com/293025
Tested-by: Samuel Tan <samueltan@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Samuel Tan <samueltan@chromium.org>
4 files changed
tree: 5eb40918244343551118bd8ddadc2e63198a851e
  1. bin/
  2. cellular/
  3. dbus/
  4. dbus_bindings/
  5. dhcp/
  6. doc/
  7. ethernet/
  8. init/
  9. mobile_operator_db/
  10. net/
  11. pppoe/
  12. setup_wifi/
  13. shims/
  14. supplicant/
  15. test-scripts/
  16. udev/
  17. upstart/
  18. vpn/
  19. wifi/
  20. wimax/
  21. .gitignore
  22. accessor_interface.h
  23. active_link_monitor.cc
  24. active_link_monitor.h
  25. active_link_monitor_unittest.cc
  26. adaptor_interfaces.h
  27. arp_client.cc
  28. arp_client.h
  29. arp_client_test_helper.cc
  30. arp_client_test_helper.h
  31. arp_client_unittest.cc
  32. arp_packet.cc
  33. arp_packet.h
  34. arp_packet_unittest.cc
  35. async_connection.cc
  36. async_connection.h
  37. async_connection_unittest.cc
  38. callbacks.h
  39. certificate_file.cc
  40. certificate_file.h
  41. certificate_file_unittest.cc
  42. chromeos_daemon.cc
  43. chromeos_daemon.h
  44. chromeos_daemon_unittest.cc
  45. connection.cc
  46. connection.h
  47. connection_diagnostics.cc
  48. connection_diagnostics.h
  49. connection_diagnostics_unittest.cc
  50. connection_health_checker.cc
  51. connection_health_checker.h
  52. connection_health_checker_unittest.cc
  53. connection_info.cc
  54. connection_info.h
  55. connection_info_reader.cc
  56. connection_info_reader.h
  57. connection_info_reader_unittest.cc
  58. connection_info_unittest.cc
  59. connection_tester.cc
  60. connection_tester.h
  61. connection_tester_unittest.cc
  62. connection_unittest.cc
  63. connectivity_trial.cc
  64. connectivity_trial.h
  65. connectivity_trial_unittest.cc
  66. control_interface.h
  67. crypto_des_cbc.cc
  68. crypto_des_cbc.h
  69. crypto_des_cbc_unittest.cc
  70. crypto_interface.h
  71. crypto_provider.cc
  72. crypto_provider.h
  73. crypto_provider_unittest.cc
  74. crypto_rot47.cc
  75. crypto_rot47.h
  76. crypto_rot47_unittest.cc
  77. crypto_util_proxy.cc
  78. crypto_util_proxy.h
  79. crypto_util_proxy_unittest.cc
  80. dbus_adaptor.cc
  81. dbus_adaptor.h
  82. dbus_adaptor_unittest.cc
  83. dbus_async_call_helper.h
  84. dbus_control.cc
  85. dbus_control.h
  86. dbus_manager.cc
  87. dbus_manager.h
  88. dbus_manager_unittest.cc
  89. dbus_name_watcher.cc
  90. dbus_name_watcher.h
  91. dbus_name_watcher_unittest.cc
  92. dbus_properties.cc
  93. dbus_properties.h
  94. dbus_properties_proxy.cc
  95. dbus_properties_proxy.h
  96. dbus_properties_proxy_interface.h
  97. dbus_properties_unittest.cc
  98. dbus_property_matchers.h
  99. dbus_service_proxy.cc
  100. dbus_service_proxy.h
  101. dbus_service_proxy_interface.h
  102. dbus_variant_gmock_printer.cc
  103. dbus_variant_gmock_printer.h
  104. default_profile.cc
  105. default_profile.h
  106. default_profile_unittest.cc
  107. device.cc
  108. device.h
  109. device_claimer.cc
  110. device_claimer.h
  111. device_claimer_unittest.cc
  112. device_dbus_adaptor.cc
  113. device_dbus_adaptor.h
  114. device_info.cc
  115. device_info.h
  116. device_info_unittest.cc
  117. device_stub.h
  118. device_unittest.cc
  119. diagnostics_reporter.cc
  120. diagnostics_reporter.h
  121. diagnostics_reporter_unittest.cc
  122. dns_client.cc
  123. dns_client.h
  124. dns_client_factory.cc
  125. dns_client_factory.h
  126. dns_client_unittest.cc
  127. dns_server_tester.cc
  128. dns_server_tester.h
  129. dns_server_tester_unittest.cc
  130. eap_credentials.cc
  131. eap_credentials.h
  132. eap_credentials_unittest.cc
  133. eap_listener.cc
  134. eap_listener.h
  135. eap_listener_unittest.cc
  136. eap_protocol.h
  137. ephemeral_profile.cc
  138. ephemeral_profile.h
  139. error.cc
  140. error.h
  141. error_unittest.cc
  142. event_dispatcher.cc
  143. event_dispatcher.h
  144. external_task.cc
  145. external_task.h
  146. external_task_unittest.cc
  147. file_io.cc
  148. file_io.h
  149. file_reader.cc
  150. file_reader.h
  151. file_reader_unittest.cc
  152. geolocation_info.cc
  153. geolocation_info.h
  154. glib.cc
  155. glib.h
  156. glib_io_handler_factory.cc
  157. glib_io_handler_factory.h
  158. glib_io_input_handler.cc
  159. glib_io_input_handler.h
  160. glib_io_ready_handler.cc
  161. glib_io_ready_handler.h
  162. HACKING
  163. hook_table.cc
  164. hook_table.h
  165. hook_table_unittest.cc
  166. http_proxy.cc
  167. http_proxy.h
  168. http_proxy_unittest.cc
  169. http_request.cc
  170. http_request.h
  171. http_request_unittest.cc
  172. http_url.cc
  173. http_url.h
  174. http_url_unittest.cc
  175. icmp.cc
  176. icmp.h
  177. icmp_session.cc
  178. icmp_session.h
  179. icmp_session_factory.cc
  180. icmp_session_factory.h
  181. icmp_session_unittest.cc
  182. icmp_unittest.cc
  183. ip_address_store.cc
  184. ip_address_store.h
  185. ip_address_store_unittest.cc
  186. ipconfig.cc
  187. ipconfig.h
  188. ipconfig_dbus_adaptor.cc
  189. ipconfig_dbus_adaptor.h
  190. ipconfig_unittest.cc
  191. key_file_store.cc
  192. key_file_store.h
  193. key_file_store_unittest.cc
  194. key_value_store.cc
  195. key_value_store.h
  196. key_value_store_unittest.cc
  197. link_monitor.cc
  198. link_monitor.h
  199. link_monitor_unittest.cc
  200. logging.cc
  201. logging.h
  202. manager.cc
  203. manager.h
  204. manager_dbus_adaptor.cc
  205. manager_dbus_adaptor.h
  206. manager_unittest.cc
  207. metrics.cc
  208. metrics.h
  209. metrics_unittest.cc
  210. mock_active_link_monitor.cc
  211. mock_active_link_monitor.h
  212. mock_adaptors.cc
  213. mock_adaptors.h
  214. mock_ares.cc
  215. mock_ares.h
  216. mock_arp_client.cc
  217. mock_arp_client.h
  218. mock_async_connection.cc
  219. mock_async_connection.h
  220. mock_certificate_file.cc
  221. mock_certificate_file.h
  222. mock_connection.cc
  223. mock_connection.h
  224. mock_connection_health_checker.cc
  225. mock_connection_health_checker.h
  226. mock_connection_info_reader.cc
  227. mock_connection_info_reader.h
  228. mock_connectivity_trial.cc
  229. mock_connectivity_trial.h
  230. mock_control.cc
  231. mock_control.h
  232. mock_crypto_util_proxy.cc
  233. mock_crypto_util_proxy.h
  234. mock_dbus_manager.cc
  235. mock_dbus_manager.h
  236. mock_dbus_properties_proxy.cc
  237. mock_dbus_properties_proxy.h
  238. mock_dbus_service_proxy.cc
  239. mock_dbus_service_proxy.h
  240. mock_device.cc
  241. mock_device.h
  242. mock_device_claimer.cc
  243. mock_device_claimer.h
  244. mock_device_info.cc
  245. mock_device_info.h
  246. mock_diagnostics_reporter.cc
  247. mock_diagnostics_reporter.h
  248. mock_dns_client.cc
  249. mock_dns_client.h
  250. mock_dns_client_factory.cc
  251. mock_dns_client_factory.h
  252. mock_dns_server_tester.cc
  253. mock_dns_server_tester.h
  254. mock_eap_credentials.cc
  255. mock_eap_credentials.h
  256. mock_eap_listener.cc
  257. mock_eap_listener.h
  258. mock_event_dispatcher.cc
  259. mock_event_dispatcher.h
  260. mock_external_task.cc
  261. mock_external_task.h
  262. mock_file_io.h
  263. mock_glib.cc
  264. mock_glib.h
  265. mock_http_request.cc
  266. mock_http_request.h
  267. mock_icmp.cc
  268. mock_icmp.h
  269. mock_icmp_session.cc
  270. mock_icmp_session.h
  271. mock_icmp_session_factory.cc
  272. mock_icmp_session_factory.h
  273. mock_ip_address_store.cc
  274. mock_ip_address_store.h
  275. mock_ipconfig.cc
  276. mock_ipconfig.h
  277. mock_link_monitor.cc
  278. mock_link_monitor.h
  279. mock_log.cc
  280. mock_log.h
  281. mock_log_unittest.cc
  282. mock_manager.cc
  283. mock_manager.h
  284. mock_metrics.cc
  285. mock_metrics.h
  286. mock_passive_link_monitor.cc
  287. mock_passive_link_monitor.h
  288. mock_pending_activation_store.cc
  289. mock_pending_activation_store.h
  290. mock_permission_broker_proxy.h
  291. mock_portal_detector.cc
  292. mock_portal_detector.h
  293. mock_power_manager.cc
  294. mock_power_manager.h
  295. mock_power_manager_proxy.cc
  296. mock_power_manager_proxy.h
  297. mock_ppp_device.cc
  298. mock_ppp_device.h
  299. mock_ppp_device_factory.cc
  300. mock_ppp_device_factory.h
  301. mock_process_killer.cc
  302. mock_process_killer.h
  303. mock_process_manager.cc
  304. mock_process_manager.h
  305. mock_profile.cc
  306. mock_profile.h
  307. mock_property_store.cc
  308. mock_property_store.h
  309. mock_resolver.cc
  310. mock_resolver.h
  311. mock_routing_table.cc
  312. mock_routing_table.h
  313. mock_service.cc
  314. mock_service.h
  315. mock_socket_info_reader.cc
  316. mock_socket_info_reader.h
  317. mock_store.cc
  318. mock_store.h
  319. mock_traffic_monitor.cc
  320. mock_traffic_monitor.h
  321. mock_virtual_device.cc
  322. mock_virtual_device.h
  323. NETLINK_MESSAGES.txt
  324. nice_mock_control.cc
  325. nice_mock_control.h
  326. OWNERS
  327. passive_link_monitor.cc
  328. passive_link_monitor.h
  329. passive_link_monitor_unittest.cc
  330. pending_activation_store.cc
  331. pending_activation_store.h
  332. pending_activation_store_unittest.cc
  333. permission_broker_proxy.cc
  334. permission_broker_proxy.h
  335. permission_broker_proxy_interface.h
  336. portal_detector.cc
  337. portal_detector.h
  338. portal_detector_unittest.cc
  339. power_manager.cc
  340. power_manager.h
  341. power_manager_proxy.cc
  342. power_manager_proxy.h
  343. power_manager_proxy_interface.h
  344. power_manager_unittest.cc
  345. ppp_daemon.cc
  346. ppp_daemon.h
  347. ppp_daemon_unittest.cc
  348. ppp_device.cc
  349. ppp_device.h
  350. ppp_device_factory.cc
  351. ppp_device_factory.h
  352. ppp_device_unittest.cc
  353. process_killer.cc
  354. process_killer.h
  355. process_killer_unittest.cc
  356. process_manager.cc
  357. process_manager.h
  358. process_manager_unittest.cc
  359. profile.cc
  360. profile.h
  361. profile_dbus_adaptor.cc
  362. profile_dbus_adaptor.h
  363. profile_unittest.cc
  364. property_accessor.h
  365. property_accessor_unittest.cc
  366. property_iterator.h
  367. property_observer.h
  368. property_observer_interface.h
  369. property_observer_unittest.cc
  370. property_store.cc
  371. property_store.h
  372. property_store_unittest.cc
  373. property_store_unittest.h
  374. protobuf_lite_streams.cc
  375. protobuf_lite_streams.h
  376. provider_db_unittest.bfd
  377. provider_interface.h
  378. refptr_types.h
  379. resolver.cc
  380. resolver.h
  381. resolver_unittest.cc
  382. result_aggregator.cc
  383. result_aggregator.h
  384. result_aggregator_unittest.cc
  385. routing_table.cc
  386. routing_table.h
  387. routing_table_entry.h
  388. routing_table_unittest.cc
  389. rpc_service_watcher_interface.h
  390. rpc_task.cc
  391. rpc_task.h
  392. rpc_task_dbus_adaptor.cc
  393. rpc_task_dbus_adaptor.h
  394. rpc_task_unittest.cc
  395. scope_logger.cc
  396. scope_logger.h
  397. scope_logger_unittest.cc
  398. scoped_umask.cc
  399. scoped_umask.h
  400. service.cc
  401. service.h
  402. service_dbus_adaptor.cc
  403. service_dbus_adaptor.h
  404. service_property_change_notifier.cc
  405. service_property_change_notifier.h
  406. service_property_change_test.cc
  407. service_property_change_test.h
  408. service_sorter.h
  409. service_under_test.cc
  410. service_under_test.h
  411. service_unittest.cc
  412. shared_dbus_connection.cc
  413. shared_dbus_connection.h
  414. shill.gyp
  415. shill.gypi
  416. shill_ares.cc
  417. shill_ares.h
  418. shill_config.cc
  419. shill_config.h
  420. shill_daemon.cc
  421. shill_daemon.h
  422. shill_export.h
  423. shill_main.cc
  424. shill_test_config.cc
  425. shill_test_config.h
  426. shill_unittest.cc
  427. socket_info.cc
  428. socket_info.h
  429. socket_info_reader.cc
  430. socket_info_reader.h
  431. socket_info_reader_unittest.cc
  432. socket_info_unittest.cc
  433. static_ip_parameters.cc
  434. static_ip_parameters.h
  435. static_ip_parameters_unittest.cc
  436. store_interface.h
  437. stub_storage.h
  438. technology.cc
  439. technology.h
  440. technology_unittest.cc
  441. TESTING
  442. testing.h
  443. testrunner.cc
  444. tethering.cc
  445. tethering.h
  446. traffic_monitor.cc
  447. traffic_monitor.h
  448. traffic_monitor_unittest.cc
  449. virtual_device.cc
  450. virtual_device.h
  451. virtual_device_unittest.cc