commit 4d42df808775f366191355ba032841ae49ea2b54
author Chris Masone <cmasone@chromium.org> Sat Jul 02 17:09:39 2011 -0700
committer Chris Masone <cmasone@chromium.org> Sun Jul 03 12:06:53 2011 -0700
tree ac5cd82c67dbcf4df1b353ada7e2ab75db818d75
parent 8a56ad63b73d221a0f20fd61d1f27bcc443eec50

[shill] Add comments in base classes saying which properties are registered in derived classes

BUG=None
TEST=None.  Just comments changed.

Change-Id: I05b65089337fe91ceefd2cb92eb8dd8adc413bbc
Reviewed-on: http://gerrit.chromium.org/gerrit/3618
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darin Petkov <petkov@chromium.org>

cellular.cc

diff --git a/cellular.cc b/cellular.cc
index acb6edc..6ab80b6 100644
--- a/cellular.cc
+++ b/cellular.cc
@@ -35,29 +35,29 @@
                                    this,
                                    "service-" + link)),
       service_registered_(false) {
-  store_.RegisterConstBool(flimflam::kScanningProperty, &scanning_);
-  store_.RegisterUint16(flimflam::kScanIntervalProperty, &scan_interval_);
-
-  store_.RegisterBool(flimflam::kCellularAllowRoamingProperty, &allow_roaming_);
   store_.RegisterConstString(flimflam::kCarrierProperty, &carrier_);
-  store_.RegisterConstString(flimflam::kMeidProperty, &meid_);
-  store_.RegisterConstString(flimflam::kImeiProperty, &imei_);
-  store_.RegisterConstString(flimflam::kImsiProperty, &imsi_);
+  store_.RegisterBool(flimflam::kCellularAllowRoamingProperty, &allow_roaming_);
   store_.RegisterConstString(flimflam::kEsnProperty, &esn_);
-  store_.RegisterConstString(flimflam::kMdnProperty, &mdn_);
-  store_.RegisterConstString(flimflam::kMinProperty, &min_);
-  store_.RegisterConstString(flimflam::kModelIDProperty, &model_id_);
-  store_.RegisterConstString(flimflam::kManufacturerProperty, &manufacturer_);
   store_.RegisterConstString(flimflam::kFirmwareRevisionProperty,
                              &firmware_revision_);
   store_.RegisterConstString(flimflam::kHardwareRevisionProperty,
                              &hardware_revision_);
+  store_.RegisterConstString(flimflam::kImeiProperty, &imei_);
+  store_.RegisterConstString(flimflam::kImsiProperty, &imsi_);
+  store_.RegisterConstString(flimflam::kManufacturerProperty, &manufacturer_);
+  store_.RegisterConstString(flimflam::kMdnProperty, &mdn_);
+  store_.RegisterConstString(flimflam::kMeidProperty, &meid_);
+  store_.RegisterConstString(flimflam::kMinProperty, &min_);
+  store_.RegisterConstString(flimflam::kModelIDProperty, &model_id_);
   store_.RegisterConstInt16(flimflam::kPRLVersionProperty, &prl_version_);
 
   // TODO(cmasone): Deal with these compound properties
   // known_properties_.push_back(flimflam::kSIMLockStatusProperty);
   // known_properties_.push_back(flimflam::kFoundNetworksProperty);
 
+  store_.RegisterConstBool(flimflam::kScanningProperty, &scanning_);
+  store_.RegisterUint16(flimflam::kScanIntervalProperty, &scan_interval_);
+
   VLOG(2) << "Cellular device " << link_name() << " initialized.";
 }